537797 - Remaining Jetpack Gallery bugs before 2nd point release push

Status: RESOLVED FIXED

(Websites Graveyard :: jetpackgallery.mozillalabs.com, defect, P2)

Description

[Daniel Buchner [:dbuc]]

The footer on stage still appears to be floating to me...http://jetpack.stage.mozilla.com/jetpacks/79

I found that the lightbox's semi-transparent overlay is borked sometimes, see attached image.  Something in the script seems to be overriding the "width: 100%" css style, I added " !important" to that style and it kicked it back into shape.

I just got this request from Pascal, please include the script tags required for Omniture tracking via the directions on the linked wiki page.

Instructions are here:
https://wiki.mozilla.org/index.php?title=IT/OmnitureSetup

PROFILENAME is mozillajetpackmozillalabscom

The div id'd as "atffc" was appearing for me on the above linked page (think it has to do with the social sharing widget), upon page reload it disappears...  Perhaps I had an old page version, when I cleared the cache, it was no longer there, and there was an iframe with an id of "_atssh" - a replacement for the flash object method perhaps?  Don't worry about it, if I come across it again, I will do a print screen of it selected in Firebug :)

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Changed min-height for content wrap from 600px to 800px. Added margin-bottom: 40px; as well.  See http://jetpack.stage.mozilla.com/licenses/1

Added the following to attempt fix for semi-transparent borkage.
#jquery-lightbox {
	width: 100% !important;
}

Omniture added.

==

Sending        application/views/kohana_error_page.php
Sending        application/views/template.php
Sending        public_html/css/main.css
Adding         public_html/js/s_code.js
Transmitting file data ....
Committed revision r59005.

Comment 2

[Daniel Buchner [:dbuc]]

"Changed min-height for content wrap from 600px to 800px. Added margin-bottom:
40px; as well."

As for the sticky footer, I implemented it on the current release and it is working great, I would like to see it carried over, the styles I used are similar to this method: http://ryanfait.com/sticky-footer/

I hate to be a stickler, but you should be able to just carry over the styles I had on the last version and it will always stick to the bottom regardless of page height.

Attached is an "In the wild" screenshot of the bug with the #atffc div that I mentioned, It seems to happen the first time I visit the site each day and click "Jetpacks" in the nav, subsequent visits show no sign of the div. Just put a style in for #atffc for display: none; should mop that up.

Other than that, pull back the layout/style changes for the list pages, "Jetpacks" and "Contributors", we will not be pushing those changes because they break the fluid item pair height changes which fixed issues previously.

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Updated sticky footer from example at http://ryanfait.com/sticky-footer/

Where's the attachment?

Please reopen the ticket for the layout / style changes that you're referring to if there's a problem.

==

Sending        public_html/css/main.css
Transmitting file data .
Committed revision r59170.

Comment 4

[Daniel Buchner [:dbuc]]

Attachment: atffc div bug

Sorry, posted without uploading attachment :(

Comment 5

[Daniel Buchner [:dbuc]]

I was under the impression this was the ticket for the style issues associated with the footer because they were posted as part of this ticket...

"Changed min-height for content wrap from 600px to 800px. Added margin-bottom:
40px; as well.  See http://jetpack.stage.mozilla.com/licenses/1"

The easy fix is to copy the style of the html, body, and footer elements as needed to achieve the same functionality as is observed on the live gallery site.

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

This is the ticket for the footer.  That has been fixed.  See comment 3. Closing this ticket.

Re-open whatever ticket is associated with your comments in comment 2.  "Other than that, pull back the layout/style changes for the list pages,
"Jetpacks" and "Contributors", we will not be pushing those changes because
they break the fluid item pair height changes which fixed issues previously."

Comment 7

[Daniel Buchner [:dbuc]]

Sorry Ryan, I totally missed that, my fault.  for the very last and final thing (100% promise!) can you set the content_wrap margin to 'margin:0 auto -140px;' instead of 'margin:0 auto -100px;' reason being is that on pages where the content is not there to push the footer down and the css takes over instead, it takes away the vertical scrollbar :)  

Try applying it here and you can see what I am talking about: http://jetpack.stage.mozilla.com/licenses/1

Again sorry for the missed comment, I feel like an a$$h0l3  :(

Comment 8

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Updated content-wrap and footer.  Also increased margin-bottom for index:#submit

==

Sending        public_html/css/main.css
Transmitting file data .
Committed revision r59500.

Comment 9

[Daniel Buchner [:dbuc]]

OK, with that all said and done, I think we are ready.  Just remember not to push the changes to the list view tab/pages for the jetpacks and contributors!

I will file a release ticket today for tomorrow Weds. January 13th