537907 - [qt] Can't type with keyboard because of broken focus

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Miika Jarvinen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6) Gecko/20091215 Ubuntu/9.04 (jaunty) Shiretoko/3.5.6 AutoPager/0.5.2.2 (http://www.teesoft.info/)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091231 Minefield/3.7a1pre

I Built qt version of Firefox. I wasn't able to write anything with keyboard, and caret doesn't show up in text editor.

Reproducible: Always

Steps to Reproduce:
1. Build and run qt build of Firefox
2. Click on address or search bar
3. Try to type with keyboard
Actual Results:  
Caret isn't visible, and you are not able to write.

Expected Results:  
Caret is visible, and you can use keyboard to write.

Comment 1

[Miika Jarvinen]

Attachment: Patch which fixes activate event and modifier handling

Attached patch which fixes keyboard input. 

Problem was: Qt build tried to send NS_ACTIVATE event for child widget, although it should send it for toplevel window. 

By changing listened event to QEvent::WindowActivate instead of QEvent::FocusIn this problem is fixed. Changes to InitKeyEvent was needed because shift key was not selecting text when moving on address bar with shift key down.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 420063 [details] [diff] [review]
Patch which fixes activate event and modifier handling

Patch works for me. Requesting review.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/6ce98ed11af8