Closed Bug 537967 Opened 11 years ago Closed 11 years ago
_ILLEGAL _CHARACTERS from ns CRT .h to ns CRTGlue .h for frozen linkages
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:22.214.171.124) Gecko/20091206 SeaMonkey/2.0.1 Build Identifier: need to include nsCRT.h in mailnews/base/public/msgCore.h to circumvent redefinition. This macros need to be uniquely accessible even after frozen linkage. Reproducible: Always Actual Results: Macro available through inclusion of "nsCRT.h" Expected Results: single source to be included. "nsCRTGlue.h" bug 525463
Assignee: nobody → ul.mcamafia
Severity: normal → trivial
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Version: unspecified → Trunk
Any other candidates to be included in this move for frozen linkage?
Comment on attachment 425723 [details] [diff] [review] Moved FILE_ILLEGAL_CHARACTERS to nsCRTGlue.h I really don't know enough about how we want to structure these header files to know where the right place to put this in is.
Attachment #425723 - Flags: review?(jonas) → review?(benjamin)
pinging for review, since it's blocking a mailnews review...
Attachment #425723 - Flags: superreview?(shaver)
This patch will be needed on branches 1.9.1 and 1.9.2 too after baking on trunk
Comment on attachment 425723 [details] [diff] [review] Moved FILE_ILLEGAL_CHARACTERS to nsCRTGlue.h sure; rs=shaver
Attachment #425723 - Flags: superreview?(shaver) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 425723 [details] [diff] [review] Moved FILE_ILLEGAL_CHARACTERS to nsCRTGlue.h a=beltzner for branches, someone please send 'er over.
Whiteboard: [checkin to mozilla-1.9.2] [checkin to mozilla-1.9.1]
You need to log in before you can comment on or make changes to this bug.