Closed Bug 538005 Opened 14 years ago Closed 14 years ago

Validator should detect Number.prototype and Boolean.prototype

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davemgarrett, Assigned: jorgev)

Details

(Whiteboard: [ReviewTeam])

Attachments

(1 file)

The add-on validator currently catches Object.prototype, String.prototype. and Array.prototype in the potentially unsafe JavaScript test. It should also treat Number.prototype and Boolean.prototype the same way.

To make the ever-growing regexp list simpler, I'd suggest just handling all disallowed extensions of base types in one line:
'/(Object|Array|String|Number|Boolean)\.prototype/',
Priority: -- → P4
Whiteboard: [required amo-editors]
Target Milestone: --- → 5.6
Added Date, since that's missing as well.
Assignee: nobody → jorge
Attachment #420160 - Flags: review?(clouserw)
Adding to 5.5, since there's a simple patch and it's related to the fix on bug 511391.
Target Milestone: 5.6 → 5.5
Attachment #420160 - Flags: review?(clouserw) → review+
r59055
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: