Closed
Bug 538005
Opened 14 years ago
Closed 14 years ago
Validator should detect Number.prototype and Boolean.prototype
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P4)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
RESOLVED
FIXED
5.5
People
(Reporter: davemgarrett, Assigned: jorgev)
Details
(Whiteboard: [ReviewTeam])
Attachments
(1 file)
886 bytes,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
The add-on validator currently catches Object.prototype, String.prototype. and Array.prototype in the potentially unsafe JavaScript test. It should also treat Number.prototype and Boolean.prototype the same way. To make the ever-growing regexp list simpler, I'd suggest just handling all disallowed extensions of base types in one line: '/(Object|Array|String|Number|Boolean)\.prototype/',
Assignee | ||
Updated•14 years ago
|
Priority: -- → P4
Whiteboard: [required amo-editors]
Target Milestone: --- → 5.6
Assignee | ||
Comment 1•14 years ago
|
||
Added Date, since that's missing as well.
Assignee: nobody → jorge
Attachment #420160 -
Flags: review?(clouserw)
Assignee | ||
Comment 2•14 years ago
|
||
Adding to 5.5, since there's a simple patch and it's related to the fix on bug 511391.
Target Milestone: 5.6 → 5.5
Updated•14 years ago
|
Attachment #420160 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•