Looking for saved searches? click on "Search Bugs" above.
nsIAlertsService::showAlertNotification with null title shows short (1px tall) alerts on Linux
RESOLVED
FIXED
in Firefox 3.7a1
Status
()
People
(Reporter: myk, Assigned: Michael Ventnor)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(2 attachments, 1 obsolete attachment)
|
5.63 KB,
image/png
|
Details | |
|
993 bytes,
patch
|
Details | Diff | Splinter Review |
Created attachment 420180 [details] screenshot showing problem If you call nsIAlertsService::showAlertNotification on Linux (Ubuntu 9.10), passing it a null argument to its second parameter ("title"), the alert will appear only one pixel tall, making its message unreadable. It should show up at normal height, with a visible message (and perhaps a default title, if necessary), or the API should report an error. See the attached screenshot to see what the notification looks like when I call showAlertNotification(null, null, "Hello, world!").
|
(Assignee) | |
Comment 1•8 years ago
|
||
Created attachment 420251 [details] [diff] [review] Patch Can't think of an automated test for this...
Attachment #420251 -
Flags: review?(roc)
Comment on attachment 420251 [details] [diff] [review] Patch the bodies of "if" and "else" should go in {}
Attachment #420251 -
Flags: review?(roc) → review+
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
Created attachment 420476 [details] [diff] [review] Patch 2 Fix comments
Attachment #420251 -
Attachment is obsolete: true
Attachment #420476 -
Flags: review?(roc)
|
|
(Assignee) | |
Updated•8 years ago
|
||
Keywords: checkin-needed
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
Comment on attachment 420476 [details] [diff] [review] Patch 2 Whoops, I have review already.
Attachment #420476 -
Flags: review?(roc)
|
||
Comment 5•8 years ago
|
||
Has a bug been filed upstream about this issue?
|
|
(Assignee) | |
Comment 6•8 years ago
|
||
No idea.
|
||
Updated•8 years ago
|
||
Assignee: nobody → ventnor.bugzilla
|
|
||
Comment 7•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/247211e7f9bc
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
You need to log in
before you can comment on or make changes to this bug.
Description
•