53810 - Security prefs not saved

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[John Unruh]

9/22 WinNT, Win98 and Linux.
1.) Open Security Manager and click on Applications.
2.) Change all of the preferences and close Security Manager.
3.) Open Security Manager and click on Applications.
What is expected: That the prefs would be saved.
What happens: The prefs are not saved.

Comment 1

[John Unruh]

Adding keywords.

Comment 2

[John Unruh]

*** Bug 54034 has been marked as a duplicate of this bug. ***

Comment 3

[David P. Drinan]

Adding keyword rtm.

Comment 4

[David P. Drinan]

Adding [rtm need info] to whiteboard.

Comment 5

[David P. Drinan]

Attachment: TLS UI and fixes for saving prefs

Comment 6

[David P. Drinan]

Javi,

Please review my changes to psm_ui.properties.in.

Comment 7

[Javier Delgadillo]

patch looks good. r=javi

Comment 8

[Scott Collins]

Most of this patch seems fine.  I'm a little confused why your toggle functions
are so verbose.  Couldn't they all follow the model, e.g.,

  function toggleTLSCipher()
  {
    enable_tls = !enable_tls;
  }

You have several of these.  The example above seems clearer to me.  I also think
it's better to write |if (enable_tls)| than |if (enable_tls == true)|.  It's
idiomatic, and reduces the brain-print your script puts on the reader.  Other
than these, the patch looks good.  Have you successfully tested these patches
(this one and the one from bug #53198)?  I've cc'd myself on this bug, as soon
as you attach the new patch, I can give you the sr=.  Just label the patch with
something that mentions my name so I notice, e.g., "updated patch as per scc's
review".

Comment 9

[David P. Drinan]

Attachment: updated patch as per scc's review comments.

Comment 10

[Scott Collins]

Looks good :-)  sr=scc

Comment 11

[David P. Drinan]

Marking this rtm+.

Comment 12

[David P. Drinan]

Marking thus rtm+ again since my previous attempt did not seem to take.

Comment 13

[Jim Roskind]

Critical functionality, but a giant patch for this point in time :-/.
Please land this on the trunk, and put the results in this bug (regressions?
smooth? etc.).  After landing on the trunk, and getting feedback for 24 hours,
renominate.
Marking rtm need info

Comment 14

[John Unruh]

The fix is not yet in the 101604 Mtrunk Win98 build.

Comment 15

[John Unruh]

*** Bug 57152 has been marked as a duplicate of this bug. ***

Comment 16

[David P. Drinan]

This bug was fixed on the trunk on Monday. Marking rtm+.

Comment 17

[selmer (gone)]

rtm++

Comment 18

[John Unruh]

This bug of sort of fixed. The pref to "Select Automatically" or "Ask Every 
Time" works, as does turning off or on SSL2. SSL3 and TLS.
However, the four Applications/Navigator prefs to turn on or off warnings are 
still not saved.
Win98 commerical Trunk 102004 build.

Comment 19

[John Unruh]

*** Bug 57680 has been marked as a duplicate of this bug. ***

Comment 20

[Jason Eager]

Did this get checked into the branch? It has now had rtm++ for 5 days!

Comment 21

[John Unruh]

The fix has not even been checked into the trunk. The bug is still there. 
The four Applications/Navigator prefs to turn on or off warnings are 
still not saved. Trunk commercial Win98 102504.

Comment 22

[Phil Peterson]

So has this been checked in on the branch or not? Left v-mail for ddrinan. If it
has not been checked in on the branch, then this fix has missed the first N6
candidate build, so we can not take it unless we respin. This bug is in
candidate limbo.  We will reconsider this fix once we have a candidate in hand,
but we can't take this fix before then. PDT marking [rtm+]

Comment 23

[John Unruh]

Linux only now. The four warning prefs under the Applications tab still are 
not saved. This works with this weekend's MN6 builds for Mac and Win98.

Comment 24

[Phil Peterson]

PDT interpretation of this is that the bug was fixed ON THE BRANCH in a way
which does not work on Linux. Marking [rtm need info] then. ddrinan, what's the
story?

Comment 25

[David P. Drinan]

This was checked into the branch. I will check on why it's still broken on 
Linux.

Comment 26

[John Unruh]

The fix is still not in the 11-1-19-MN6 Linux build.

Comment 27

[selmer (gone)]

What's the current status of this bug?  A quick update would help a lot.  Thanks.

Comment 28

[Javier Delgadillo]

If it's not in the daily builds yet, we'll have to provide a new drop of PSM to
fix this.  (I believe the TLS prefs are saved, just some of the SSL related
prefs--entering secure, viewing secure, leaving secure--don't stick.)

Comment 29

[David P. Drinan]

Leaf has just informed me that he has just picked up the correct PSM xpi files 
for Linux. This should be fixed in the next N6 build.

Comment 30

[Jason Eager]

So should this move off the rtm radar now that it has been fixed for rtm?

Comment 31

[John Unruh]

Fixed in the 11/3 morning trunk build.

Comment 32

[nitinp]

verified on the 2000-11-03-09-MN6 build on win2k , winNT that security prefs can
are saved.

Comment 33

[John Unruh]

Removing vbranch keyword, and marking verified.

Comment 34

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 35

[John Unruh]

Mass changing Security:Crypto to PSM