Last Comment Bug 538127 - [BUGZILLA] Handle long field names in the what field better
: [BUGZILLA] Handle long field names in the what field better
Status: ASSIGNED
:
Product: Webtools
Classification: Server Software
Component: Mozbot (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Reed Loden [:reed] (use needinfo?)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-06 03:20 PST by Reed Loden [:reed] (use needinfo?)
Modified: 2014-07-17 09:19 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch - v1 (1.62 KB, patch)
2010-01-06 03:20 PST, Reed Loden [:reed] (use needinfo?)
bugtrap: review-
Details | Diff | Splinter Review
Bugmail used to test the patch... (2.64 KB, application/octet-stream)
2010-01-10 04:53 PST, Wolf [:wolf]
no flags Details

Description Reed Loden [:reed] (use needinfo?) 2010-01-06 03:20:15 PST
Created attachment 420299 [details] [diff] [review]
patch - v1

See the following example:

Mark Banner (:standard8) <> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 blocking-thunderbi|?                           |needed
              rd3.0|                            |
         AssignedTo|nobody@mozilla.org          |bienvenu@.com
  Status Whiteboard|[223 Migration]             |[223 Migration][blocks a
                   |                            |major upgrade]
               Flag|                            |blocking-thunderbird3.1+


<firebot> bugzilla@standard8.....com set blocking-thunderbi to needed on bug 534448.

The What wrapped to the next line.

Untested patch that will hopefully fix the problem.
Comment 1 Wolf [:wolf] 2010-01-06 04:36:07 PST
Will this also fix the problems where addresses get broken in the removed/added columns as well? (we frequently get space separated addresses in lines because of the line breaks
Comment 2 Reed Loden [:reed] (use needinfo?) 2010-01-06 06:42:11 PST
(In reply to comment #1)
> Will this also fix the problems where addresses get broken in the removed/added
> columns as well? (we frequently get space separated addresses in lines because
> of the line breaks

Don't think so, but I did start looking into that, and I have an idea what's causing it. That's another bug, though.
Comment 3 Wolf [:wolf] 2010-01-09 06:21:50 PST
D:\FIREBOT>patch -p0 < 538127
patching file BotModules/BugzillaMailHandler.pl
Hunk #1 succeeded at 242 (offset 1 line).

Feel free to test and let me know if it works :-)
Comment 4 Wolf [:wolf] 2010-01-10 04:52:37 PST
536854::::Thunderbird::::General::::::::reed@reedloden.com::::rd3.0 rd3.0::::---::::?::::reed@reedloden.com changed the rd3.0 rd3.0 on bug 536854 from --- to ?.
536854::::Thunderbird::::General::::::::reed@reedloden.com::::CC::::::::reed@reedloden.com::::reed@reedloden.com added reed@reedloden.com to the CC field on bug 536854.
536854::::Thunderbird::::General::::::::reed@reedloden.com::::3.0 3.0::::---::::unaffected::::reed@reedloden.com changed the 3.0 3.0 on bug 536854 from --- to unaffected.

it doesn't seem to work too well...
Comment 5 Wolf [:wolf] 2010-01-10 04:53:44 PST
Created attachment 420949 [details]
Bugmail used to test the patch...

Note You need to log in before you can comment on or make changes to this bug.