D'oh, I should have caught this in review. The old setTimeout(eval, ...) trick! /be
I'm currently not getting a crash on a fresh 1.9.2 build on OSX. Has this already been fixed or something?
(In reply to comment #2) > I'm currently not getting a crash on a fresh 1.9.2 build on OSX. Has this > already been fixed or something? Sorry. I was running the wrong build. This does crash for me.
Looks like it was probably this: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e3ed50c322a5 It looks like that patch moved the definition of staticLevel up to avoid some kind of GCC warning/error on Linux. But the previous line of code checks if caller is NULL, so clearly that condition has to be guarded against.
Created attachment 420415 [details] [diff] [review] Proposed fix This patch makes us follow trunk, which should help any other backporting woes.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #420415 - Flags: review?(dmandelin)
Attachment #420415 - Flags: review?(dmandelin) → review+
Attachment #420415 - Flags: approval220.127.116.11?
disable test on 1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9a6239590bb1
Comment on attachment 420415 [details] [diff] [review] Proposed fix We missed 18.104.22.168. Moving approval request forward.
Attachment #420415 - Flags: approval22.214.171.124? → approval126.96.36.199?
Comment on attachment 420415 [details] [diff] [review] Proposed fix Approved for 188.8.131.52, a=dveditz for release-drivers
Attachment #420415 - Flags: approval184.108.40.206? → approval220.127.116.11+
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
status1.9.2: --- → .4-fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2
You need to log in before you can comment on or make changes to this bug.