Closed
Bug 538165
Opened 15 years ago
Closed 15 years ago
Harden GCHeap against new virtual memory API behavior
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: treilly, Assigned: treilly)
Details
Attachments
(1 file)
|
1.31 KB,
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
Desktop platforms reserve API's have always returned either NULL or the address you asked for but on wince and linux we're seeing results that are sometimes close to the asked for address and the GCHeap needs to handle this. This also is what our VMPI docs say can happen ironically.
|
Assignee | |
Comment 1•15 years ago
|
||
Looking for quick review, this is a player/tr rectification fix (although player needs clean up too)
|
||
Updated•15 years ago
|
Attachment #420332 -
Attachment is patch: true
Attachment #420332 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 420332 [details] [diff] [review] handles VMPI_reserveMemory returning different address than asked for Presumably in the test newRegionAddr != NULL && newRegionAddr == region->reserveTop the first conjunct is redundant because reserveTop is never NULL?
Attachment #420332 -
Flags: superreview?(lhansen) → superreview+
|
|
Assignee | |
Comment 3•15 years ago
|
||
changeset 3459 5bcf95ed4a0a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•