Harden GCHeap against new virtual memory API behavior

VERIFIED FIXED

Status

Tamarin
Garbage Collection (mmGC)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Tommy Reilly, Assigned: Tommy Reilly)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Desktop platforms reserve API's have always returned either NULL or the address you asked for but on wince and linux we're seeing results that are sometimes close to the asked for address and the GCHeap needs to handle this.  This also is what our VMPI docs say can happen ironically.
(Assignee)

Comment 1

9 years ago
Created attachment 420332 [details] [diff] [review]
handles VMPI_reserveMemory returning different address than asked for

Looking for quick review, this is a player/tr rectification fix (although player needs clean up too)
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Attachment #420332 - Flags: superreview?(lhansen)

Updated

9 years ago
Attachment #420332 - Attachment is patch: true
Attachment #420332 - Attachment mime type: application/octet-stream → text/plain

Comment 2

9 years ago
Comment on attachment 420332 [details] [diff] [review]
handles VMPI_reserveMemory returning different address than asked for

Presumably in the test

newRegionAddr != NULL && newRegionAddr == region->reserveTop

the first conjunct is redundant because reserveTop is never NULL?
Attachment #420332 - Flags: superreview?(lhansen) → superreview+
(Assignee)

Comment 3

9 years ago
changeset 3459	5bcf95ed4a0a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
Engineering work item.  Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.