538215 - Add reftests with SMIL animations in external document resources

Status: RESOLVED INVALID

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

Up until Bug 537157 landed this morning, we were vulnerable to crashes on any testcase that had a <use> element that referred to an external document, if the external document included SMIL animations of CSS properties.

Crash was on a null window pointer.  In debug builds, we'd abort just before the null deref, with this message: "ABORT: actively animated document w/ no window: 'win', file ../../../mozilla/content/smil/nsSMILCSSProperty.cpp"

At the moment, we don't have any tests that cover this situation -- so I'm filing this bug on adding some, along with some reftests for animations in XBL bindings. (per bug 537157)

Comment 1

[Robert Longson [:longsonr]]

I don't think we support SMIL in external documents any more.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: (resources SVG for testcase)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: testcase 1 (demonstrating that SMIL animations don't work in external resource docs)

Comment 4

[Daniel Holbert [:dholbert]]

Good point! I believe that's true.

The attached testcase renders lime for me, which I believe confirms that it's true.

(In reply to Daniel Holbert [:dholbert] from comment #0)

along with some reftests for animations in
XBL bindings. (per bug 537157)

Heh. XBL is gone as of a few years ago too, per https://bgrins.github.io/xbl-analysis/