53825 - Mac classic should be using Mac style common dialog alert icons

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P4)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Currently the mac classic skin is using the same icons as MOdern1 for common
dialogs such as alert, confirm, etc. It needs to use the icon images used by the
Mac  platform for such dialogs.

Comment 1

[Matthew T (active 1999-2002)]

Does the same apply to Windows Classic, or has that already been fixed?

Note that fixing this bug will expose another bug: that a number of dialogs are
using a meaningless `question mark' icon, one which has never had a native
equivalent on Mac OS, and one where the native equivalent on Windows has been
deprecated (Microsoft says not to use it) since Windows 95.

Comment 2

[andreww]

Taking Ben's Mac Classic skin bugs...

Comment 3

[hangas]

Themes Triage Team P4

Comment 4

[Matthew T (active 1999-2002)]

Mine!

Comment 5

[Matthew T (active 1999-2002)]

Attachment: mozilla/themes/classic/global/mac/error-icon.gif

Comment 6

[Matthew T (active 1999-2002)]

Attachment: mozilla/themes/classic/global/mac/message-icon.gif

Comment 7

[Matthew T (active 1999-2002)]

Attachment: mozilla/themes/classic/global/mac/alert-icon.gif (not a very specific name, that ...)

Comment 8

[Matthew T (active 1999-2002)]

The bug for expunging that nasty question-icon.gif is bug 59820.

My message-icon.gif contains one unused palette entry, because I can't get 
Photoshop to save a GIF without it being a GIF89a, and message-icon.gif doesn't 
have any transparent pixels but it allocates the palette entry for transparent 
pixels anyway.

CCing lordpixel for review, Ben for approval, and Blake for the checkin.

Comment 9

[timeless]

wouldn't theme:// be a better aproach?

Comment 10

[Andrew Thompson]

timeless, theme: could do this (using Icon Services) .. but currently its a bunch 
of demos not a viable skin or replacement for classic. Indeed, its not even part 
of the build. For now, the consensus seems to be to keep taking patches which 
improve Classic as it is today, as that's what'll ship in 1.0.

mpt: icons look fine to me. Don't worry about the colour palette stuff, so long 
as its reasonably minimised - most GIF editors won't let you have a colour 
palette size that's not a power of 2 in any case (1 bit, 2 bit etc.). Not sure 
what the actual GIF spec allows for... I think GIF87 is dead and buried though.

r=lordpixel

Comment 11

[Joe Hewitt (gone)]

Much nicer.  Modern's alert icons could use some polish too.

sr=hewitt

Comment 12

[Matthew T (active 1999-2002)]

I have r= and sr=, need someone to check these in ...

Comment 13

[andreww]

I've volunteered to check it in...

Comment 14

[andreww]

ok, files checked into trunk...

Comment 15

[Matthew T (active 1999-2002)]

I see these icons in build 2001041908, Mac OS 9.1. Marking fixed.

Comment 16

[Patty Mac]

marking verified on Mac (2001-04-25-09-Mtrunk).