Closed Bug 538251 Opened 14 years ago Closed 14 years ago

Clean up NULL-checking of mGeckoChild in nsChildView.mm

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smichaud, Assigned: smichaud)

Details

Attachments

(1 file)

For some time code in nsChildView.mm's ChildView class has
NULL-checked its mGeckoChild variable to detect the deletion of its
corresponding nsChildView/nsIWidget object.

But recently new code was added without the appropriate NULL checks,
and as a result the following crash stack has started showing up among
the OS X topcrashers (towards the bottom):

http://crash-stats.mozilla.com/query/query?version=ALL%3AALL&platform=mac&date=&range_value=1&range_unit=weeks&query_search=signature&query_type=contains&query=setMarkedText&do_query=1

I've gone through nsChildView.mm and added NULL checks where they were
missing.  I'll post a patch in my next comment (later today or
tomorrow).
Assignee: nobody → smichaud
Attached patch FixSplinter Review
Attachment #420445 - Flags: review?(joshmoz)
Attachment #420445 - Flags: review?(masayuki)
Comment on attachment 420445 [details] [diff] [review]
Fix

Thank you for the fix.
Attachment #420445 - Flags: review?(masayuki) → review+
Attachment #420445 - Flags: review?(joshmoz) → review+
Landed on trunk:
http://hg.mozilla.org/mozilla-central/rev/eae745ef62c1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: