538259 - Do not allow add-on versions to have multiple files which are supported on ALL platforms

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

At https://addons.mozilla.org/de/thunderbird/addon/594 , there are two download buttons for the extension:

- https://addons.mozilla.org/de/thunderbird/downloads/file/65526/virtual_identity-0.5.12-tb+sm.xpi
- https://addons.mozilla.org/de/thunderbird/downloads/latest/594/addon-594-latest.xpi?src=addondetail

Looks like the first one should be there.

Comment 1

[Wil Clouser [:clouserw]]

This is because there are 2 files uploaded for that version, both for all platforms.  Looks like one is in the sandbox and one is public.  -> jorge for solutions :)

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I deleted the sandboxed version. However, the public version doesn't exist on the server. I've contacted the author about this, and told him to upload a new file with a different version number.

The duplicate button should disappear within a couple of hours.

Comment 3

[krupa raj[:krupa]]

There is another addon which has the same problem-https://addons.mozilla.org/en-US/mobile/search?q=lazyclick&cat=all&advancedsearch=1&as=1&appid=60&lver=any&atype=0&pp=20&pid=3&sort=&lup=


Should we allow users to upload multiple files for the same version with same option(in this case,all platforms)?

Comment 4

[Pratibha]

Few more examples of add-ons with two download buttons:
https://addons.mozilla.org/en-US/firefox/search?q=Leo+Search&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=Torbutton&cat=all
https://addons.mozilla.org/en-US/firefox/search?q=iSyndica+Tools&cat=all

Comment 5

[Pratibha]

Dual Add to Firefox buttons and going to details page dual Continue to Download buttons are present:
Office Options - https://preview.addons.mozilla.org/en-US/firefox/addon/87458/
iSyndica Tools - https://preview.addons.mozilla.org/en-US/firefox/addon/80211/
WordReference Translator - https://preview.addons.mozilla.org/en-US/firefox/search?q=WordReference+Translator&cat=all

Comment 6

[Pratibha]

multiple Download Now buttons are present  going to details page :

Search Tools- https://preview.addons.mozilla.org/z/en-US/seamonkey/addon/9583/

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

I've fixed the add-ons listed so far by deleting all the duplicate files. However, we should definitely mitigate the problem by only showing one button even if there are multiple files for the same version with compatibility for ALL.

Comment 8

[krupa raj[:krupa]]

This problem happens on the versions page as well. See- https://preview.addons.mozilla.org/en-US/firefox/addon/10868/versions/?page=1#version-0.5

That version of that add-on has two files for the option "ALL"

Comment 9

[Pratibha]

contains dual  Add to Firefox button:
Tested with
https://next.addons.mozilla.org/en-US/firefox/search/?sort=averagerating&pp=20&pid=1&cat=all&lver=any&page=3&advanced=on

https://next.addons.mozilla.org/en-US/firefox/addon/6971/

Comment 10

[Wil Clouser [:clouserw]]

comment 8 is the only place I still see this

Comment 13

[Pratibha]

Another add-on found with two Add to Firefox buttons:
https://addons.mozilla.org/en-US/firefox/addon/live-search/