Closed Bug 538269 Opened 15 years ago Closed 14 years ago

Set HOST_AR_FLAGS when HOST_AR is set

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

Make the setting of HOST_AR and HOST_AR_FLAGS consistent.
Attached patch Set HOST_AR_FLAG like HOST_AR (obsolete) — Splinter Review
Assignee: nobody → mwu
Status: NEW → ASSIGNED
Attachment #420421 - Flags: review?(ted.mielczarek)
Attachment #420421 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 420421 [details] [diff] [review]
Set HOST_AR_FLAG like HOST_AR

>+    if test -z "$HOST_AR_FLAGS"; then
>+        HOST_AR_FLAGS="$AR_FLAGS"
>+    fi
AR_FLAGS doesn't get set until later.

>-HOST_AR_FLAGS='$(AR_FLAGS)'
When I hacked configure.in to get my cross-compile working, I just made HOST_AR_FLAGS='cr $@' here.
Comment on attachment 420421 [details] [diff] [review]
Set HOST_AR_FLAG like HOST_AR

Going to post a new patch later which will also fix cross compile for Neil.
Attachment #420421 - Attachment is obsolete: true
Neil - can you try this patch and see if it works?
Comment on attachment 423025 [details] [diff] [review]
Set HOST_AR_FLAG like HOST_AR, v2

Neil confirmed this patch works on IRC. It's messier than before but I'm not sure if there is a better way to deal with AR_FLAGS.
Attachment #423025 - Flags: review?(ted.mielczarek)
Attachment #423025 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/e1e378876084
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: