538315 - Image exterminator is not working

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

1. Go to <https://support.mozilla.com/tiki-admin.php?locale=en-US&page=gal>.
2. Scroll down to the "Exterminator" section and click [Remove]. Let the page finish processing.
3. Go to <https://support.mozilla.com/tiki-editpage.php?locale=en-US&page=*For%20Internet%20Explorer%20Users>.

At the bottom of the editor, there are a bunch of images that are not used in the article. They should have been removed by the exterminator.

Comment 1

[Chris Ilias [:cilias]]

More info:
After I click on [Remove], I get sent to a blank page. (after some time of processing)

Comment 2

[Chris Ilias [:cilias]]

Moving to 1.6. We've had 2 instances today of this today (now that I know to be suspicious of article edits, in which there is no difference in the markup).

https://support.mozilla.com/tiki-editpage.php?locale=en-US&page=*Options%20window%20-%20General%20panel

https://support.mozilla.com/tiki-editpage.php?locale=en-US&page=*Will%20Firefox%20work%20on%20Windows%207

One could easily upload a pornographic image, and we wouldn't be able to remove it.

Comment 3

[James Socol [:jsocol, :james]]

Chris: Is this a tiki feature, or did we add it? If it's the former, let's test it on tiki-trunk.m.c and see if this is still a bug. If it's the latter, we probably need to get that upstreamed.

Comment 4

[Chris Ilias [:cilias]]

It was implemented in bug 449440.

Comment 5

[James Socol [:jsocol, :james]]

It looks like this functionality may be substantially different in Tiki 5, (bug 449440 comment 22) so we should probably verify that the problem exists at all on tiki-trunk.m.c (once it's stable, anyway).

Comment 6

[Paul Craciunoiu [:paulc]]

I can have a crack at this one sometime this week. No idea how it works yet but how bad could it be? (Don't answer that)

Comment 7

[Chris Ilias [:cilias]]

FWIW, it looks like this broke around the time of sumo 1.5.

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: v1, perf improvements and ignore_user_abort

This patch makes some improvements to the performance of the exterminator function and adds an ignore_user_abort to keep the script running (thanks to James for the latter).

Moving all the array_unique()s out helped a lot (basically takes half the time now).

Comment 9

[James Socol [:jsocol, :james]]

Comment on attachment 433204 [details] [diff] [review]
v1, perf improvements and ignore_user_abort

WFM.

For testers: you may still see blank pages (time outs) while running the image exterminator, but the process should continue in the background, and will eventually complete.

Comment 10

[Paul Craciunoiu [:paulc]]

r64320/r64321

Chris, please test this on stage now.

Comment 11

[Chris Ilias [:cilias]]

The images from prod on not on stage, so I added an image to <https://support-stage.mozilla.com/en-US/kb/Will%20Firefox%20work%20on%20Windows%207>, approved it, then removed it and approved that removal.

I then went to <https://support-stage.mozilla.com/tiki-admin.php?locale=en-US&page=gal>, and ran the image exterminator. Now when I go to <https://support-stage.mozilla.com/tiki-editpage.php?locale=en-US&page=*Will%20Firefox%20work%20on%20Windows%207>, the image is not available.

Thanks a lot!

Comment 12

[Chris Ilias [:cilias]]

So verified on prod now! :-) And it doesn't even time out!

Comment 13

[Paul Craciunoiu [:paulc]]

Woot!

Comment 14

[James Socol [:jsocol, :james]]

(In reply to comment #13)
> Woot!

Woot, indeed! Nice work, Paul.

Comment 15

[Paul Craciunoiu [:paulc]]

Thank you James. You deserve credit for the ignore_user_abort() part though :)