Closed Bug 538362 Opened 11 years ago Closed 10 years ago

rename nsIDocument::GetPrimaryShell to nsIDocument::GetShell

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: smaug, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 2 obsolete files)

.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #450928 - Flags: review?(Olli.Pettay)
Comment on attachment 450928 [details] [diff] [review]
Patch

>--- a/accessible/src/base/nsAccessibilityService.cpp
>+++ b/accessible/src/base/nsAccessibilityService.cpp
>@@ -198,21 +198,21 @@ nsAccessibilityService::GetInfo(nsIFrame
>   nsIContent* content = aFrame->GetContent();
>   if (!content)
>     return NS_ERROR_FAILURE;
> 
>   nsIDocument* document = content->GetOwnerDoc();
>   if (!document)
>     return NS_ERROR_FAILURE;
> 
>-  NS_ASSERTION(document->GetPrimaryShell(),"Error no shells!");
>+  NS_ASSERTION(document->GetShell(),"Error no shells!");
Want to fix the assertion comment.
shells -> shell

(The assertion seems bogus, but I don't know a11y code well enough to be sure.)

>diff --git a/content/base/public/nsIDocument.h b/content/base/public/nsIDocument.h
>--- a/content/base/public/nsIDocument.h
>+++ b/content/base/public/nsIDocument.h


You're changing an interface so please update
NS_IDOCUMENT_IID

http://mozilla.pettay.fi/cgi-bin/mozuuid.pl gives it in js and C++ form.
Attachment #450928 - Flags: review?(Olli.Pettay) → review+
Attached patch Patch v2 (obsolete) — Splinter Review
Thanks
Attachment #450928 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
bz added a new consumer in <http://hg.mozilla.org/mozilla-central/rev/dee1e84a95aa>, fixing that.
Attachment #450941 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/0dd4e086cea5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
Flags: in-testsuite-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.