538362 - rename nsIDocument::GetPrimaryShell to nsIDocument::GetShell

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 450928 [details] [diff] [review]
Patch

>--- a/accessible/src/base/nsAccessibilityService.cpp
>+++ b/accessible/src/base/nsAccessibilityService.cpp
>@@ -198,21 +198,21 @@ nsAccessibilityService::GetInfo(nsIFrame
>   nsIContent* content = aFrame->GetContent();
>   if (!content)
>     return NS_ERROR_FAILURE;
> 
>   nsIDocument* document = content->GetOwnerDoc();
>   if (!document)
>     return NS_ERROR_FAILURE;
> 
>-  NS_ASSERTION(document->GetPrimaryShell(),"Error no shells!");
>+  NS_ASSERTION(document->GetShell(),"Error no shells!");
Want to fix the assertion comment.
shells -> shell

(The assertion seems bogus, but I don't know a11y code well enough to be sure.)

>diff --git a/content/base/public/nsIDocument.h b/content/base/public/nsIDocument.h
>--- a/content/base/public/nsIDocument.h
>+++ b/content/base/public/nsIDocument.h


You're changing an interface so please update
NS_IDOCUMENT_IID

http://mozilla.pettay.fi/cgi-bin/mozuuid.pl gives it in js and C++ form.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Thanks

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v3 (merged to tip)

bz added a new consumer in <http://hg.mozilla.org/mozilla-central/rev/dee1e84a95aa>, fixing that.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0dd4e086cea5