Closed
Bug 538412
Opened 15 years ago
Closed 15 years ago
JIT should not call intToAtom() just to attempt constant folding
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: edwsmith, Unassigned)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
LirHelper::nativeToAtom() attemps to constant-fold constant integers if they fit in Atom, but not otherwise; it calls core->intToAtom() which results in an allocation if the int doesn't fit. the allocation is instant garbage and interferes with background compilation. instead the jit should call atomIsValidIntptrValue() which avoids allocation.
|
Reporter | |
Updated•15 years ago
|
Target Milestone: --- → Future
|
|
Reporter | |
Comment 1•15 years ago
|
||
Attachment #420661 -
Flags: review?(siwilkin)
|
|
Reporter | |
Updated•15 years ago
|
Attachment #420661 -
Flags: review?(siwilkin) → review?(rreitmai)
|
||
Updated•15 years ago
|
Attachment #420661 -
Flags: review?(rreitmai) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
pushed last week http://hg.mozilla.org/tamarin-redux/rev/82e397659f5d
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•