538442 - A webpage can override <select /> method and prevent the formfill to works correctly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

a testcase is here : 
http://people.mozilla.com/~mrbkap/fennec.html

The patch also remove some unneeded wrappedJSObject call since we don't react on webpage event as before for formfill but handle them directly thought getElementFromPoint in browser.js

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#1878

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 420588 [details] [diff] [review]
Patch

Looks good, but we should test in as many cases as apoosible. I mean, we have bugs releated to formfill, and we fixed them. Let's make sure we don't regress.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

s/apoosible/possible

s/releated /related

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Seems to work without the XPCNativeWrapper call but we need to remove the .wrappedJSObject

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 420808 [details] [diff] [review]
Patch v0.2

Looks like this is a subset of attachment 420824 [details] [diff] [review], which I r+ed over in that bug :)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Should be fixed by https://hg.mozilla.org/mobile-browser/rev/5253f931db37 .

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

wfm
mrbkap can you confirm that it works for you?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Yep, this was fixed by bug 537555. Thanks!

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds :

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100112 Firefox/3.6pre Fennec/1.1a1pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20100112 Firefox/3.7a1pre Fennec/1.1a1pre

Comment 9

[Martijn Wargers (dead)]

I'm reassigning this to myself for adding litmus testcases for this (aakashd discussed this on irc with blassey and ted on #mobile).

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: testcase

Here's the testcase from http://people.mozilla.com/~mrbkap/fennec.html for posterity.

Comment 11

[Martijn Wargers (dead)]

https://litmus.mozilla.org/show_test.cgi?id=13627