Closed Bug 538455 Opened 10 years ago Closed 10 years ago

release maemo repo updates need to deal with deb renames

Categories

(Release Engineering :: General, defect)

ARM
Maemo
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aki, Assigned: aki)

References

Details

Attachments

(6 files, 2 obsolete files)

Currently, I figure out the fennec deb name by pulling mobile-browser default and sourcing confvars.sh, then looking for fennec_VERSION_armel.deb in the appropriate locations.

This is broken with the deb renames.

I can do the confvars step for release debs (until we start putting a +STRING in the name), but I have to pull mobile-browser from the relbranch.  I can't rely on confvars.sh for nightlies, since there will be a ~DATETIME in there.

The release update fix is needed today for rc2; the nightlies would be good to fix by tomorrow.
Attached patch fix the repo update triggers (obsolete) — Splinter Review
This should work for now.

I'm going to work on bug 530597 (ssh poller) for a longer term fix; if that doesn't work the fallback is sendchanges.

Tested in staging. Everything worked, except nightly l10n updates (which didn't have anything to download due to bug 538699).
Attachment #420859 - Flags: review?(nrthomas)
Comment on attachment 420859 [details] [diff] [review]
fix the repo update triggers 

>+        else:
>+            self.addStep(SetProperty,
>+             command=['ssh', '-i', self.env['SSH_KEY'],
>+                      '%s@%s' % (self.env['STAGE_USERNAME'],
>+                                 self.env['STAGE_SERVER']),
>+                      'find '+self.stageFennecPath+' -maxdepth 1 '+
>+                      '-name fennec\*_armel.deb | head -1'],
>+             extract_fn=self.get_fennec_version,
>+             haltOnFailure=True
>+            )

In this nightly case, why is the file you want guaranteed to be found first ?

It may also be possible to collapse the many similar path definitions by knowing that you can use /pub/mozilla.org/... instead of /home/ftp/pub/...
Attached patch 2nd trySplinter Review
.... because I was thinking about using ls -1t, then decided to try find even though it doesn't auto-sort.

Switched back, collapsed all the pub/... paths.

patch 1 of 2.
Attachment #420859 - Attachment is obsolete: true
Attachment #421169 - Flags: review?(nrthomas)
Attachment #420859 - Flags: review?(nrthomas)
Also only removes the applicable .install file rather than *.install; this will allow us to have nightly and release paths in the same repo if we want.
Attachment #421170 - Flags: review?(nrthomas)
Comment on attachment 421169 [details] [diff] [review]
2nd try

Stampy stamp stamp.
Attachment #421169 - Flags: review?(nrthomas) → review+
Attachment #421170 - Flags: review?(nrthomas) → review+
Comment on attachment 421170 [details] [diff] [review]
update signdebs.mk to take stage_dir

http://hg.mozilla.org/build/tools/rev/5ea00b73d19b
Attachment #421170 - Flags: checked-in+
Blocks: maemo4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Looks like in this one spot (production nightlies) I put STAGE_PATH instead of STAGE_DIR in the config.  One of the downsides of testing staging configs and interpolating production configs, but I'm not sure how to fix that.
Attachment #421885 - Flags: review?(catlee)
Attachment #421885 - Flags: review?(catlee) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
This is borked for releases.
I think it's time to write sshpoller.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I had to hardcode the xulrunner version and this assumes that the fennec deb version is in default-version.txt, which is a bad assumption.

(My xulrunner hack didn't work when we set the xulrunner version to 1.9.2.1+rc1; that's not in the deb control file)

For releases, I can actually set the deb names in the configs, if sshpoller is going to take too long to write.
Ok, this works. I was able to manually repack an en-US deb with fy-NL and install that deb and verify the localization.

Caveats:

 - I've got a dup DEB_PKG_VERSION define here (also in installer/Makefile.in), which isn't ideal. Not sure what the best way to centralize that is.
 - We were getting by without using scratchbox to repack. No longer... now a requirement due to libhildon + dpkg-deb.

I'll add Axel to the r? since I think this was originally his stuff.

I'm going to dup bug 544031 to this one since I'll fix both with this patch (or subsequent ones). Built this patch from Stuart's original fix in https://bugzilla.mozilla.org/attachment.cgi?id=425020 .
Attachment #427511 - Flags: review?(mark.finkle)
Attachment #427511 - Flags: review?(l10n)
Wait, this is so the wrong bug =P
Fixing...
Attachment #427511 - Attachment is obsolete: true
Attachment #427511 - Flags: review?(mark.finkle)
Attachment #427511 - Flags: review?(l10n)
Blocks: 550023
Summary: repo updates need to deal with deb renames → release maemo repo updates need to deal with deb renames
I removed the hardcoded xulrunner hack from this makefile for 1.1, since we won't ship a xulrunner deb after 1.0.x.  However, since we're shipping a 1.0.1 and there is a xulrunner deb on the relbranch, I needed to add something.

This allows for a url or set of urls to be added for download.
Attachment #434431 - Flags: review?(jhford)
This patch:

- brings the configs closer to 1.0.1 rc1 build1,
- refactors a bit to get the release and nightly configs more similar,
- adds extra_debs_list,
- removes confvars.sh hack; removes ssh hack; reads deb_name.txt for deb_name,
- removes xulrunner references

Tested in debsign-staging.
Attachment #434434 - Flags: review?(jhford)
Comment on attachment 434431 [details] [diff] [review]
allow for downloading extra debs in the repo

stamp!
Attachment #434431 - Flags: review?(jhford) → review+
Attachment #434434 - Flags: review?(jhford) → review+
Comment on attachment 434431 [details] [diff] [review]
allow for downloading extra debs in the repo

http://hg.mozilla.org/build/tools/rev/074184ea9263
Attachment #434431 - Flags: checked-in+
debsign master updated.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.