538508 - Clicking "Ask again" just appends--rather than replaces--article search results from the AAQ form.

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Clicking "Ask again" just appends--rather than replaces--article search results from the AAQ form.

STR:

1. Load http://support-stage.mozilla.org/en-US/forum/1?openpost=1
2. Choose the last radio button and click "Next step"
3. On the next screen, click "Next step" again
4. Now, type anything ("Google") and click "Ask this"
5. Click "Ask again"

Expected Results:

We should just replace the set of results, IMHO (even if the search term changes), rather than appending

Actual Results:

For the same search term, we just keep appending each set of results

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[James Socol [:jsocol, :james]]

/agree with the expected result. Every search should clear and repopulate the results (unless, I suppose, the query doesn't change, then it doesn't necessarily need to go back, but it's probably easiest to do it every time).

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: clear contents before appending

Wow. How did I miss this? Thank you Stephen.

Comment 4

[James Socol [:jsocol, :james]]

Comment on attachment 420780 [details] [diff] [review]
clear contents before appending

Works great.

Comment 5

[Paul Craciunoiu [:paulc]]

r59655

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!

(I think we should expose the fact that the minimum search-query length is 5 characters, but that's a separate bug.)

Comment 7

[Paul Craciunoiu [:paulc]]

Stephen: if you could, file that and assign it to me, by all means.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> Stephen: if you could, file that and assign it to me, by all means.

Bug 539313, thanks!

Comment 9

[James Socol [:jsocol, :james]]

Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.

Comment 10

[James Socol [:jsocol, :james]]

On branch, r62441

Comment 11

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.