Closed
Bug 538509
Opened 14 years ago
Closed 14 years ago
l10n repacks for maemo5 gtk
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Whiteboard: [l10n][fennec][q2goal])
Attachments
(1 file, 2 obsolete files)
19.60 KB,
patch
|
jhford
:
review+
armenzg
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
.
Updated•14 years ago
|
Whiteboard: [l10n]
Assignee | ||
Updated•14 years ago
|
Assignee: aki → nobody
Priority: -- → P3
Updated•14 years ago
|
Priority: P3 → --
Updated•14 years ago
|
Priority: -- → P3
Assignee | ||
Updated•14 years ago
|
Whiteboard: [l10n] → [l10n][fennec]
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → aki
Priority: P3 → --
Whiteboard: [l10n][fennec] → [l10n][fennec][q2goal]
Assignee | ||
Comment 1•14 years ago
|
||
Waiting for staging env to tell me how horked this patch is.
Assignee | ||
Comment 2•14 years ago
|
||
Debs are currently horked for Maemo5 QT builds due to bug 555351. I'll file a couple other bugs to track that, so this isn't blocked.
Summary: l10n repacks for qt- and non-qt- maemo5 → l10n repacks for maemo5 gtk
Assignee | ||
Comment 3•14 years ago
|
||
This one actually creates the builders the way I want :) Letting the builds run on staging; if everything goes well I'll r?
Attachment #443255 -
Attachment is obsolete: true
Assignee | ||
Comment 4•14 years ago
|
||
This works. The previous patch didn't override enUS_binaryURL, so it was downloading the maemo4 deb to repack. Now fixed & ready for review.
Attachment #443530 -
Attachment is obsolete: true
Attachment #443645 -
Flags: review?(jhford)
Assignee | ||
Updated•14 years ago
|
Attachment #443645 -
Flags: review?(armenzg)
Comment 5•14 years ago
|
||
Comment on attachment 443645 [details] [diff] [review] now with 100% more enUS_binaryURL >diff --git a/mozilla2-staging/mobile_config.py b/mozilla2-staging/mobile_config.py >+ > for toolkit in ['gtk', 'qt']: > for branch in MOBILE_BRANCHES.keys(): > if 'qt' in toolkit and '1.9.2' in branch: > continue > maemo5 = deepcopy(MOBILE_BRANCHES[branch]['platforms']['linux-gnueabi-arm']) > maemo5['base_name'] = "Maemo 5 %s %s" % (toolkit.upper(), > hacktionary.get(branch, branch)) > if 'qt' in toolkit: >- maemo5['glob_list'] = ['dist/*.tar.*'] >+ maemo5['glob_list'] = ['dist/*.tar.*', 'dist/*.zip'] > maemo5['debs'] = False >- else: >- maemo5['glob_list'] = ['dist/*.tar.bz2', >- 'dist/deb_name.txt', >- 'mobile/*.deb'] >+ maemo5['enable_multi_locale'] = False We only disable multilocale for "qt"? >+ elif 'l10n_platforms' in MOBILE_BRANCHES[branch]: >+ MOBILE_BRANCHES[branch]['l10n_platforms']['maemo5-%s'%toolkit] = 'linux' >+ maemo5['enUS_binaryURL'] = '%s-maemo5-%s' % \ >+ (MOBILE_BRANCHES[branch]['enUS_binaryURL'], toolkit) No 'glob_list' for this "elif" condition? Using default from deepcopy? No more "else" statement? > if 'electrolysis' in branch: > maemo5['mozconfig'] += "-%s-e10s" % toolkit > maemo5['mobile_repo_path'] = 'users/pavlov_mozilla.com/mobile-e10s' > else: > maemo5['mozconfig'] += "-%s" % toolkit > maemo5['base_workdir'] = '%s/build/%s-maemo5-%s' % (SBOX_HOME, > branch, toolkit) > maemo5['base_builddir'] = '%s-maemo5-%s' % (branch, toolkit) > maemo5['base_upload_dir'] = '%s-maemo5-%s' % (branch, toolkit) > maemo5['base_l10n_workdir'] = '%s/build/%s-maemo5-%s-l10n' % (SBOX_HOME, > toolkit, branch) > maemo5['sb_target'] = 'FREMANTLE_ARMEL' >- maemo5['enable_multi_locale'] = False > MOBILE_BRANCHES[branch]['platforms']['maemo5-%s'%toolkit] = maemo5 > This patch looks good. I will give r+ after answers.
Assignee | ||
Comment 6•14 years ago
|
||
> >+ maemo5['enable_multi_locale'] = False > We only disable multilocale for "qt"? Correct. Qt builds don't create debs yet, so we're not turning on l10n for them yet. Which is why we have the following elif create the l10n_platforms: > >+ elif 'l10n_platforms' in MOBILE_BRANCHES[branch]: > >+ MOBILE_BRANCHES[branch]['l10n_platforms']['maemo5-%s'%toolkit] = 'linux' > No 'glob_list' for this "elif" condition? Using default from deepcopy? > No more "else" statement? Yeah, the maemo5 gtk and maemo4 gtk packageGlobList should be the same now. I figured it was cleaner to just remove it than duplicate.
Updated•14 years ago
|
Attachment #443645 -
Flags: review?(armenzg) → review+
Comment 7•14 years ago
|
||
(In reply to comment #6) > > >+ elif 'l10n_platforms' in MOBILE_BRANCHES[branch]: > > >+ MOBILE_BRANCHES[branch]['l10n_platforms']['maemo5-%s'%toolkit] = 'linux' > > > No 'glob_list' for this "elif" condition? Using default from deepcopy? > > No more "else" statement? > > Yeah, the maemo5 gtk and maemo4 gtk packageGlobList should be the same now. > I figured it was cleaner to just remove it than duplicate. Could you please add a comment there to make it clear? r=me with this nit. Good job aki!
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Comment 8•14 years ago
|
||
Comment on attachment 443645 [details] [diff] [review] now with 100% more enUS_binaryURL this looks good
Attachment #443645 -
Flags: review?(jhford) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #443645 -
Flags: checked-in+
Assignee | ||
Comment 9•14 years ago
|
||
Comment on attachment 443645 [details] [diff] [review] now with 100% more enUS_binaryURL http://hg.mozilla.org/build/buildbot-configs/rev/d906b5568349
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•