Closed
Bug 538525
Opened 15 years ago
Closed 15 years ago
Simplify nsBlockFrame::PullFrame/PullFrameFrom
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(2 files)
|
13.31 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.98 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
PullFrame always returns NS_OK. It "retries" the call when PullFrameFrom
returns PR_TRUE, but PullFrameFrom always returns PR_FALSE so this is
unnecessary code complexity.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Dropped the aFrameResult param, now it's the return value.
Removed the "retry" code since that never happens.
Moved the doc comments to the header file.
Attachment #420679 -
Flags: review?(bzbarsky)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 420679 [details] [diff] [review]
Patch rev. 1 (wdiff)
roc, can you grab this? I can sort it out if I need to, but this is more your area of expertise.
Attachment #420679 -
Flags: review?(bzbarsky) → review?(roc)
Comment on attachment 420679 [details] [diff] [review]
Patch rev. 1 (wdiff)
- else {
+
Don't add this blank line.
Attachment #420679 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
With the above nit fixed:
http://hg.mozilla.org/mozilla-central/rev/6fe511bc5001
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•