53865 - clicking column in file picker won't sort

Status: VERIFIED FIXED

Description

[sairuh (rarely reading bugmail)]

found using 2000.09.22.08 opt comm bits on linux. spun off of bug 52789 --the
default file listing in the file picker is now correctly sorted
alphanumerically, but clicking the columns to sort by mod-date and file-size

1. bring up file picker (either Ctrl+O or File > Open File).
2. click on either the Size or Last Modified column.

result: cannot sort by size or last mod-date. alas, no console output...

Comment 1

[sairuh (rarely reading bugmail)]

bryner sez he has an easy fix for this...

Comment 2

[sairuh (rarely reading bugmail)]

linux, er unix-only.

Comment 3

[Peter Trudelle]

nsbeta3-/future, not needed for N6 (wasn't even in N4.X!)

Comment 4

[Brian Ryner (not reading)]

jag offered to take this...

Comment 5

[Peter ``jag'' Annema]

Taking.

Comment 6

[Peter ``jag'' Annema]

Created attachment 17157 [details]
[patch] xpfe/global/resources/content/treeSort.js

Comment 7

[Peter ``jag'' Annema]

Created attachment 17158 [details] [diff] [review]
[patch] treeSort.js in jar.mn, make filepicker.xul sort

Comment 8

[Peter ``jag'' Annema]

The treeSort.js I've attached here includes more than strictly needed, it's part
of work in progress for bug 56694.

Comment 9

[Brian Ryner (not reading)]

r=bryner

Comment 10

[Peter ``jag'' Annema]

I'm working moving the sorting code into the tree widget itself (yay XBL!),
marking this depend on bug 56694.

Comment 11

[sairuh (rarely reading bugmail)]

bryner, should you take this? spoke w/jag who sez that your outliner work might
cover this. :)

Comment 12

[Peter ``jag'' Annema]

Mass move to [e-mail]

Comment 13

[Peter Trudelle]

This is fixed, sez jag ( and it is)..

Comment 14

[sairuh (rarely reading bugmail)]

yep...fixed some time ago (methinks i verified a similar bug for this recently. :)