538673 - jstests.py throws an exception when it can't get the directory name for "jstests.list"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Maybe this doesn't affect other systems, but at least on my Linux machine running 2.6.2 jstests.py throws this exception:

[jwalden@the-great-waldo-search tests]$ python ./jstests.py ../dbg/js
Traceback (most recent call last):
  File "./jstests.py", line 324, in <module>
    os.chdir(os.path.dirname(OPTIONS.manifest))
OSError: [Errno 2] No such file or directory: ''

Looking more closely, it looks like the manifest detection is finding "jstests.list" as the path to it; when we pass that to os.path.dirname, the result is "", which understandably throws off os.chdir.  It seems to me that we should just use the second item in filenames, that being the jstests.list that's a sibling to the currently-running jstests.py, which works just fine for me.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch 2

That patch busts on my Mac because it tries to change dirs to '' before running the tests. Can you try this one?

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 420823 [details] [diff] [review]
Patch 2

Works for me, but...weird.  So effectively this is being run:

  file = os.path.join(os.path.dirname(__file__), 'jstests.list')
  dir = os.path.dirname(file)
  os.chdir(dir)

What's os.path.dirname(__file__) on your system?  And what's the join returning?  I'm trying to understand how your system returns something that would have the empty string as a dirname; it just doesn't make sense by normal Unix path conventions to me.

Comment 3

[David Mandelin [:dmandelin]]

(In reply to comment #2)
> (From update of attachment 420823 [details] [diff] [review])
> Works for me, but...weird.  So effectively this is being run:
> 
>   file = os.path.join(os.path.dirname(__file__), 'jstests.list')
>   dir = os.path.dirname(file)
>   os.chdir(dir)
> 
> What's os.path.dirname(__file__) on your system?

It's ''. I think the os.path functions mostly do string manipulation without trying to canonicalize things (unless you ask for that), so a relative path like 'foo.py' has dirname ''.

Comment 4

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/tracemonkey/rev/ee08be15b932

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/ee08be15b932