Several source files express a desire to be changed now that bug 154892 is fixed

ASSIGNED
Assigned to

Status

()

--
minor
ASSIGNED
9 years ago
9 years ago

People

(Reporter: jruderman, Assigned: fantasai.bugs)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
http://hg.mozilla.org/mozilla-central/annotate/0a062eef0c8c/layout/generic/nsLineLayout.h#l386

// XXX remove this when landing bug 154892 (splitting absolute positioned frames)
friend class nsInlineFrame; 

http://hg.mozilla.org/mozilla-central/annotate/0a062eef0c8c/layout/generic/nsAbsoluteContainingBlock.cpp#l385

// When bug 154892 is checked in, make sure that when
// GetChildListName() == nsGkAtoms::fixedList, the height is unconstrained.
// since we don't allow replicated frames to split.
(Assignee)

Updated

9 years ago
Assignee: nobody → fantasai.bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 453835 [details] [diff] [review]
patch

Removed the comment, but not the friend declaration, for the first bit. We use mBlockRS in nsInlineFrame for splitting floats, so removing it doesn't compile.

Removed the other comment; we handle that case by passing in a parameter instead of adding a check, but the issue is addressed.
Attachment #453835 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.