53874 - dialogBindings.xml uses obsolete <interface> element

Status: RESOLVED FIXED

(Core :: XBL, defect, P3)

Description

[John Morrison]

Prompted by bug #52891, where a similar bit of obsolete syntax was breaking
working code, here is another instance where the XBL needs to be updated
(otherwise it is broken).

dialogBindings.xml
 14       </xul:box>
 15     </content>
 16     <interface>
 17       <property name="title" onset="this.setAttribute('title',val); return 
val;"
 18                              onget="return this.getAttribute('title');"/>
 19       <property name="description" 
onset="this.setAttribute('description',val); return val;"
 20 

uses <interface>

Nom: nsbeta3,rtm as this is a simple, safe fix, to make working code work
again, has minimum risk  (one-line XBL change to match current syntax).

Comment 1

[don]

We don't need this for beta 3.  Ben, should we fix this for RTM?

Comment 2

[Peter "jag" Annema]

Why are we using two nearly similar but not quite dialogBindings.xml files?
One in global, the other in communicator.

I don't see the differences justifying having two files, so is there another
reason for keeping both?

Anyway, attaching a patch.

Comment 3

[Peter "jag" Annema]

Attachment: [patch] interface -> implementation

Comment 4

[verah (gone)]

Nav triage team: rtm-  We don't see how this affects users -- so not a top 
priority.

Comment 5

[verah (gone)]

Marking Future.

Comment 6

[Peter "jag" Annema]

Taking this.

Comment 7

[Peter "jag" Annema]

r=hyatt

Comment 8

[Peter "jag" Annema]

Checked in on the trunk. Since this bug is nsbeta3-, rtm-, I'm going to mark it
fixed.