Closed
Bug 538825
Opened 15 years ago
Closed 15 years ago
checkbox to specify locale is available for all pages and may confuse our users
Categories
(addons.mozilla.org Graveyard :: Localization, defect, P2)
addons.mozilla.org Graveyard
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
5.6
People
(Reporter: krupa.mozbugs, Assigned: davedash)
References
Details
Attachments
(1 file)
11.99 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
"Show only <locale> addons" checkbox is available in the footer for all pages but for now is only applicable to Search and sort pages.This might be confusing for users who'd notice the checkbox on pages like collections directory and expect the selection to work for those pages as well.
Comment 1•15 years ago
|
||
agreed, this should also filter the recommended list on the front page.
Assignee | ||
Comment 2•15 years ago
|
||
Yes, the intent was to not overburden QA with testing this feature and to roll it out to the rest of the site by next iteration.
If there's other pages, other than the recommendations, I could certainly use a decent list.
Target Milestone: 5.5 → 5.6
Updated•15 years ago
|
Priority: -- → P2
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•15 years ago
|
||
This applies xenophobia everywhere. Here's what's changed:
1. In order to make debugging easier, status is now addon_status in sphinx. It's apparently a keyword in the mysql-sphinx client.
2. We are now indexing whether an addon is recommended.
3. Recommended/newly added/updated/popular addons are now served from sphinx.
4. Category Landing is now served via sphinx.
5. Fixed a lot of notice errors for listed addons.
6. Limits are tricky in sphinx since we actually need to use array_slice rather than Sphinx's own limit since we want unique addon_ids.
Attachment #423443 -
Flags: review?(clouserw)
Comment 4•15 years ago
|
||
Comment on attachment 423443 [details] [diff] [review]
v1
That's a big patch, but is a lot cleaner if it works. Let's get it landed so we can all poke on it.
Attachment #423443 -
Flags: review?(clouserw) → review+
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•