Closed Bug 538890 Opened 11 years ago Closed 11 years ago

improve legibility of about:buildconfig

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
In about:buildconfig, it looks much better if the table headings "Compiler", "Version", "Complier flags" are left-aligned.

The ugly large fonts go away when changing the Doctype from HTML 4.01 Transitional, which triggers Quirks mode, to HTML5 (just <!DOCTYPE html>).

Oh, shouldn't we add a license to this file?
Attachment #420974 - Flags: review?(mano)
Comment on attachment 420974 [details] [diff] [review]
patch

>-<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
> #filter substitution
>+<!DOCTYPE html>

Without being a real reviewer here, can we keep the <!DOCTYPE ...> as the first line in the file, will help autodiscovery of file type by actual editors. (Anything MANO says overrides me)
Feel free to add a licence if you are changing the file for other reasons. Please get it from here:
http://www.mozilla.org/MPL/boilerplate-1.1/

Gerv
Doesn't seem like there's anything in that file worth licensing, but I defer to Gerv.
Attached patch patch v1.1Splinter Review
1. Kept the <!DOCTYPE ...> in the first line per comment 1.

2. Added a license header per comment 2. about:buildconfig was created by "hacker formerly known as seawood@netscape.com <netscape@seawood.org>" in bug 140034 in February 2003. I assume seawood was a Netscape employee at that time, so the initial developer is Netscape Communications Corporation.
Attachment #420974 - Attachment is obsolete: true
Attachment #423234 - Flags: review?(mano)
Attachment #420974 - Flags: review?(mano)
Attachment #423234 - Flags: review?(mano) → review?(gavin.sharp)
Comment on attachment 423234 [details] [diff] [review]
patch v1.1

Basically getting rid of "HTML 4.01 Transitional" plus adding 3 lines of css.
Attachment #423234 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/b24fcc30c53c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.