All users were logged out of Bugzilla on October 13th, 2018

[WINDOWS] mimetype.description should not contain (*.suffix)

VERIFIED FIXED in mozilla1.2beta

Status

()

P4
normal
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: bugzilla, Assigned: serhunt)

Tracking

Trunk
mozilla1.2beta
All
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PL2:NA], URL)

Attachments

(1 attachment)

2.59 KB, patch
peterlubczynski-bugs
: review+
Details | Diff | Splinter Review
(Reporter)

Description

18 years ago
If you look at the about:plugins page the mimetype.description incorrectly 
contains *.suffix information.
Fx the "Netscape Navigator Plug-in for Adobe Acrobat v4.05"
mimetype.description is "Acrobat (*.pdf)"

in Netscape 4.x the description is just "Acrobat" which is correct. The suffix 
info can be retrived from the mimetype.suffixes

Expected:
the "mimetype.description" returns just the description not any info about the 
suffixes!
(Reporter)

Updated

18 years ago
Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because
the Netscape engineer it is assigned to is overburdened.
Target Milestone: --- → Future
(Reporter)

Comment 2

18 years ago
the "Description" field contains reduntant info, since suffixes can be obtained 
via the "Suffixes" object.

Netscape 4.x didn't include suffixes in "Description".
Keywords: 4xp
(Reporter)

Comment 3

17 years ago
I'm not sure how Netscape 4.x did this but Mozilla seems to just read the
FileOpenName property of the plugin file. This is done in:
http://lxr.mozilla.org/mozilla/source/modules/plugin/base/src/nsPluginsDirWin.cpp#405

perhaps someone could look at how Netscape 4.x did this?

Comment 4

17 years ago
Nav4 also gets the description from the FileOpenName property, but it strips off 
the suffix information. A little experimentation suggests that it strips off 
everything starting with the last open parenthesis found in the string. (In 
other words, it's a hack.)

Comment 5

17 years ago
the suffix comes from the plug-in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → INVALID

Comment 6

17 years ago
The FileOpenName field contains both the description and the suffix, as is
required by the plug-in specification. When a script queries the description,
Mozilla returns the entire FileOpenName field instead of correctly parsing out
the description. Granted that this is a very minor problem, but marking it
INVALID in this way implies that there is something wrong with what the plug-ins
are doing, which is not true.

Comment 7

17 years ago
Yeah, if 4.x did this, we really should emulate. There may be JS out there
depending on this quirk.

Here's how 4.x did it:
http://lxr.netscape.com/nova/source/lib/plugin/npwplat.cpp#655
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Comment 8

17 years ago
--->taking bug
Assignee: av → peterl
Severity: normal → minor
Status: REOPENED → NEW
OS: All → Windows XP
Priority: P3 → P4
Summary: mimetype.description should not contain (*.suffix) → [WINDOWS] mimetype.description should not contain (*.suffix)
Target Milestone: Future → mozilla1.2beta

Updated

17 years ago
Severity: minor → normal
(Assignee)

Comment 9

17 years ago
I have a patch.
Assignee: peterl → av
(Assignee)

Comment 10

17 years ago
Created attachment 91144 [details] [diff] [review]
patch v.1

I did not make it platform specific. Not sure if this should be Windows only.
Please review.

Comment 11

17 years ago
Comment on attachment 91144 [details] [diff] [review]
patch v.1

r=peterl
Attachment #91144 - Flags: review+

Updated

17 years ago
Whiteboard: [PL2:NA]

Comment 12

17 years ago
Comment on attachment 91144 [details] [diff] [review]
patch v.1

sr=alecf
Attachment #91144 - Flags: superreview+
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Whiteboard: [PL2:NA] → [PL2:NA][ready to check in]
(Assignee)

Comment 13

16 years ago
In the trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago16 years ago
Resolution: --- → FIXED
Whiteboard: [PL2:NA][ready to check in] → [PL2:NA]

Comment 14

16 years ago
verified fixed on trunk 0812. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.