539031 - Let developers move their add-ons from beta to public

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Comment 1

[Justin Scott [:fligtar]]

The files would need to be reviewed before going public.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: allow developers to change files status from beta -> sandbox or public

Comment 3

[Jeff Balogh (:jbalogh)]

fligtar and I decided that this should be a <select> on the version detail page, available if your status is beta, sandbox, or public

Comment 4

[Jeff Balogh (:jbalogh)]

QA: There should be a <select> on the version detail page (not the list) if the file has a status of Beta, Sandbox, or Public.

A trusted add-on like Weave should be able to switch a file between (BSP). https://preview.addons.mozilla.org/en-US/developers/versions/10868/

A normal add-on like Flagfox should be able to switch between (BS). https://preview.addons.mozilla.org/en-US/developers/versions/5791

If a file does not already have a (BSP) status, it shouldn't be modifiable. https://preview.addons.mozilla.org/en-US/developers/versions/58840/

If you're clever, you can try POSTing the data that would be sent to modify the status there, to make sure it's denied/ignored on the backend.

If this was zamboni, I would have written these tests in code, not words!

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 422838 [details] [diff] [review]
allow developers to change files status from beta -> sandbox or public

If the version is already public, that needs to be in the dropdown, not just trusted add-ons.  Otherwise any modification on the page changes the status to Beta (first in the list)

Comment 6

[Jeff Balogh (:jbalogh)]

Attachment: allow developers to change files status from beta -> sandbox or public

Comment 7

[Wil Clouser [:clouserw]]

With that check, they'll be able to stay on public, but if they move to beta they'll never be able to go back to public.

When an author moves an add-on from public->sandbox we let them reverse it.  The same should happen here -- if the file was previously public it should be allowed to be public again.

Comment 8

[Justin Scott [:fligtar]]

fwiw I'm fine with not being able to reverse it. I think adding the higheststatus stuff to every version will make things way more complicated than is needed.

Comment 9

[Jeff Balogh (:jbalogh)]

r61107, with a warning r+'d by clouserw on IRC. http://grab.by/1Xzq

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED based on testing in comment 4 and some more exploratory testing; didn't find anything thus far.