539102 - Entering "(" or "&" moves formfill to elements

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100111 Firefox/3.6pre Fennec/1.1a1pre

Steps to Reproduce:
1. Go to maps.google.com
2. Tap on the search field to bring up formfill
3. Press fn (blue arrow) + h to enter a "("

Actual Results:
Formfill will move to the "search maps" button

Expected Results:
"(" should be entered into the field

Comment 1

[Aakash Desai [:aakashd]]

Also, entering "&" moves formfill to the previous element.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch makes the keypress handler only check event.keyCode since we are only interested in the arrow keys. It happens that event.charCode _can_ give the same value as DOM_VK_LEFT and DOM_VK_RIGHT for combinations of non-arrow keys.

Other code in Mozilla that tests for arrow keys only uses event.keyCode to do the check.

tested on desktop and N900. '(' and '&' work as expected. Arrows keys do move the focus between controls.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default:
http://hg.mozilla.org/mobile-browser/rev/ac41a659c3ea

Comment 7

[Antonio Gomes (tonikitoo)]

js version of snav suffer the same problem in the past:  bug 471229

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100119 Firefox/3.6pre Fennec/1.1a1pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20100119 Firefox/3.7a1pre Fennec/1.1a1pre