Closed Bug 539120 Opened 10 years ago Closed 10 years ago

Dragging a Tab onto the Home Button does nothing

Categories

(Firefox :: General, defect)

3.6 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- final-fixed

People

(Reporter: drew, Assigned: mak)

Details

(Keywords: regression, relnote, verified1.9.2, Whiteboard: [3.6.x])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6 (.NET CLR 3.5.30729)

Dragging a tab to the home button does not prompt the user if he/she wants to set it as the homepage.  Dragging bookmarks or website icons, however, does prompt the user regarding the homepage.  For consistency, dragging a tab should also prompt the user regarding the homepage.
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100111 Minefield/3.7a1pre

Regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c4e00b34bbdd&tochange=a8daae5ef5ce
Flags: blocking-firefox3.6?
Keywords: regression
Severity: enhancement → major
OS: Windows Vista → Windows XP
I'm guessing that this is to do with the drag'n'drop pieces.

Enn?
Mano fixed this the last two times it happened (bug 491530, bug 465910), so he might be interested in helping to fix it again.

One of those bugs had been blocking-firefox3.5+, fwiw.
One wonders how the hell we don't have a test for this, if it keeps breaking.

Mano's kind of out of pocket. Copying his past reviewers for similar patches in bug 487263 and bug 471499. Can one of you guys take a look at this? I think we might have to suck up the functional regression for release day, but would want a patch ready in the wings for an RC ridealong if that happens.
(In reply to comment #4)
> One wonders how the hell we don't have a test for this, if it keeps breaking.

d&d tests are hard, complete d&d tests are practically impossible afaik. we can just simlulate dragstart and drop, not the full interaction.

the only thing that jumps to my eyes is that browserDragAndDrop.dragOver is missing "text/x-moz-text-internal" flavor, but i don't know if that's all offhand.
Attached patch Patch v1.0Splinter Review
yeah, was just not marked as accepting the drop

now, i could try to make a test with synthesizeDrop, but i'm not sure it will catch these kind of things, indeed i think it won't be really useful.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #421629 - Flags: review?(mconnor)
Flags: in-litmus?
Attachment #421629 - Flags: review?(mconnor) → review+
Component: Bookmarks & History → Tabbed Browser
QA Contact: bookmarks → tabbed.browser
Severity: major → normal
Component: Tabbed Browser → General
OS: Windows XP → All
QA Contact: tabbed.browser → general
Hardware: x86 → All
http://hg.mozilla.org/mozilla-central/rev/973dab910358
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Flags: blocking-firefox3.6? → blocking-firefox3.6-
Keywords: relnote
Whiteboard: [3.6.x][rc-ridealong]
(In reply to comment #5)
> (In reply to comment #4)
> > One wonders how the hell we don't have a test for this, if it keeps breaking.
> 
> d&d tests are hard, complete d&d tests are practically impossible afaik. we can
> just simlulate dragstart and drop, not the full interaction.

There are ways to synthesize drag-and-drop native events on every platform we support, I'm pretty sure.  If we need to extend our test or event tools to support simulation of more parts of D&D in our own toolkit, though, then why don't we do that?  Given that we've now fixed this bug for the 3rd time, and only narrowly avoided regressing it in 3.6, it would seem a wise investment for the people who are doing work with app-level D&D!
Comment on attachment 421629 [details] [diff] [review]
Patch v1.0

a192=beltzner, please land on mozilla-1.9.2 and GECKO192_20100105_RELBRANCH
Attachment #421629 - Flags: approval1.9.2+
Verified on xp, mac, and linux using the RC2.
Keywords: verified1.9.2
Whiteboard: [3.6.x][rc-ridealong] → [3.6.x]
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.