539171 - Test staging and approval on tiki-trunk.mozilla.com (The main test to see if we are close to being ready for SUMO & Tiki5 code sync)

Status: RESOLVED INVALID

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Marc Laporte]

Of all the code in SUMO destined to be merged for Tiki5, the one that worries me the most is Staging & Approval

1- It's complex logic/code

2- It's not used extensively (because tricky to setup)

3- It touches many parts of the code, and many of which have been massively revamped over the last 2 years
a) Edit page
b) Categories (Staging & approval is based on categories)
c) Multilingual
With all the code having moved around...

4- Several bugs have been reported and none that have been opened in 2008 and 2009 have been closed.
http://dev.tikiwiki.org/Staging+and+Approval

5- It wasn't working robustly in Tiki3 and Tiki4. Ex.: It has been reporting as never been working when http://doc.tikiwiki.org/Structures are used.

6- Perhaps there are some SUMO staging fixes that were never upstreamed because the code had already diverged too much.

Until we try, we won't know. I am expecting there will be quite a bit of debugging and probably some re-engineering to do. 

We need this done before the freeze on January 31st. Thus, we need at least basic testing now to provide LPH with time to solve.

We need a working profile as well:
http://profiles.tikiwiki.org/Staging_and_Approval

I think this feature is very important.
http://doc.tikiwiki.org/Wiki+Page+Staging+and+Approval

On the positive side, once we have tested that Staging is working as it should, most of what we need will have been tested along the way :-)

Thanks!

Comment 1

[Laura Thomson :laura]

David will take the initial round of QA.  Pass it on when you like.

Comment 2

[Marc Laporte]

Super!

David: Don't worry about theme/template.  Just test the logic/content and report any issues in time so we can upstream before January 31st freeze. You can do this on a local install of trunk if you want (though you would need to import data) or reproduce Staging & Approval logic/setup.

In my quick tests on http://tiki-trunk.mozilla.com/, I ran into an a series of issues. I am not familiar with how it was setup before so I don't want to get into reporting the issues officially. But here is a quick test:

1- Attempt to create page. A * (for staging) is pre-pended to the page name, but then Tiki complains that that * is not a recommended character and I should maybe remove

2- If I go along, it asks me to approve my own page
a) If I am admin, is this relevant (shouldn't page be pre-approved)?
b) If I am supposed to get someone else to check my work, shouldn't it warn me? ("you change has been submitted, please ask someone to review" 
c) If I do approve my edit, I get an error "Either staging or approved page cannot be found" at tiki-approve_staging_page.php and

3- Page is not created.

And this doesn't cover the more complex case of staging & approval for translations.