539239 - Pass correct document to ReparentContentWrapper

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

This looks like fallout from bug 418755, when we changed back from throwing WRONG_DOCUMENT_ERR to implicitly adopting we didn't revert to using the owner document of the original document as the "old" document for reparenting wrappers. I also removed an unused argument.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Wrong patch.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v2

I realized we can actually remove this call to ReparentContentWrapper. If the node is inserted into a different document we'll adopt it first, which does the reparenting. We still need to reparent for XUL nodes and form controls, I think there's a bug about that but can't find it right now.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 422217 [details] [diff] [review]
v2

-    if (!newContent->IsXUL()) {
-      nsContentUtils::ReparentContentWrapper(newContent, aParent,
-                                             container->GetOwnerDoc(),
-                                             container->GetOwnerDoc());
-    }
+    // FIXME We need to reparent here for nodes for which the parent of their
+    //       wrapper is not the wrapper for their ownerDocument (XUL elements,
+    //       form controls, ...).

Is there a bug on file for doing this?

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to comment #3)
> Is there a bug on file for doing this?

I thought there was, but I can't find it. If filed bug 544654.

Comment 5

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/794c61af2b5a