Closed Bug 539284 Opened 10 years ago Closed 10 years ago

n900: "Read More" links on slashdot perform no action on first click

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
ARM
Maemo
defect
Not set

Tracking

(fennec1.1+)

VERIFIED FIXED
Tracking Status
fennec 1.1+ ---

People

(Reporter: aakashd, Assigned: mfinkle)

Details

Attachments

(1 file, 1 obsolete file)

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100112 Firefox/3.6pre Fennec/1.1a1pre


Steps to Reproduce:
1. Go to www.slashdot.org
2. Scroll down to the "Read Mode" link on an entry
3. Click on the "Read More" link

Actual Results:
Clicking on the link does nothing after the blue highlighting.

Expected Results:
The link should load the comments page of the entry.
Severity: major → normal
This is worse than that for me : no link works on slashdot.org (tested on desktop/linux) zoomed or not zoomed.
Nothing appears in the js console.
humm, i'm starting to wondering if something on the page is not blocking us :
 * any first click on a link won't work
 * any first click on a link with Ctrl pressed works
By the way i need to go back to revision 967 to see it working again.
Summary: n900: clicking on "Read More" links on slashdot perform no action → n900: "Read More" links on slashdot perform no action on first click
tracking-fennec: ? → 1.1+
Attached patch patch (obsolete) — Splinter Review
This patch makes the element explicitly focused on mousedown. I tried other ways, like sending mouseover / mouseout events in the mousedown / mouseup callbacks with no success.
Assignee: nobody → fabrice.desre
Attachment #436188 - Flags: review?(mark.finkle)
Comment on attachment 436188 [details] [diff] [review]
patch


>     mouseDown: function mouseDown(cX, cY) {
>       if (!this._overlayTimeout)
>         this._overlayTimeout = setTimeout(function(self) { self._showCanvas(cX, cY); }, kTapOverlayTimeout, this);
>+      let [elementX, elementY] = Browser.transformClientToBrowser(cX, cY);
>+      let element = Browser.elementFromPoint(elementX, elementY);
>+      gFocusManager.setFocus(element, Ci.nsIFocusManager.FLAG_NOSCROLL);
>     },
> 
>     mouseUp: function mouseUp(cX, cY) {
>     },

Can we try this in mouseUp ?
Maybe I'm wrong but I don't see any needs (actually at least) to focus during mousedown or during mouseup.

I think we should just do that when we're going to dispatch a click, so when it make sense.
(In reply to comment #7)
> Maybe I'm wrong but I don't see any needs (actually at least) to focus during
> mousedown or during mouseup.
> 
> I think we should just do that when we're going to dispatch a click, so when it
> make sense.

Yes, that would be even better. We had some bugs filed earlier about "focusing" elements on mousedown and then panning, so I wanted to avoid that. But focusing on click is best.
Attached patch patch 2Splinter Review
Patch based on Fabrice's patch, but moves the focus call into "singleClick". The "executeSoon" is needed to allow the focus to happen before sending the click.
Assignee: fabrice.desre → mark.finkle
Attachment #436188 - Attachment is obsolete: true
Attachment #436494 - Flags: review?(21)
Attachment #436188 - Flags: review?(mark.finkle)
Comment on attachment 436494 [details] [diff] [review]
patch 2

I hope this won't cause weird performance bug.
Attachment #436494 - Flags: review?(21) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/1dfc6b80394e

Thanks for getting this started Fabrice!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100402 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100402 Namoroka/3.7a4pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
QA Contact: maemo-linux → general
You need to log in before you can comment on or make changes to this bug.