53934 - xcDLL.cpp leak for m_instance

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Jon Smirl]

The commented out code causes the leak

nsDll::~nsDll(void)
{
#if 0
    // The dll gets deleted when the dllStore is destroyed. This happens on
    // app shutdown. At that point, unloading dlls can cause crashes if we have
    // - dll dependencies
    // - callbacks
    // - static dtors
    // Hence turn it back on after all the above have been removed.
    Unload();
#endif

Comment 1

[Jon Smirl]

Attachment: Patch to enable DLL unloading in XPCOM standalone

Comment 2

[Asa Dotzler [:asa]]

Setting Jon Smirl's bugs to New

Comment 3

[Ray Whitmer]

Transferring to default XPCOM owner.

Comment 4

[dprice (gone)]

I'm adopting all of warren's leaks.

Comment 5

[dprice (gone)]

-> cathleen for a new home

Comment 6

[Matthias Versen [:Matti]]

-> cathleen

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 15568 [details] [diff] [review]
Patch to enable DLL unloading in XPCOM standalone

Bit-rotted by
<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/xpcom/components/xcDll.cpp>
{{
1.60	dougt%netscape.com	2002-06-21 12:58	 	151604 - XPCOM Glue standalone stupport of dynamically loading symbols. r=dp/rpotts sr=alecf

1.69	dougt%meer.net	2003-05-04 23:06	 	Missed this checkin when I landed. It is required to prevent a hang. I am also disabling some DEBUG_dougt code. r=darin, a=seth, bug=193442
}}

Comment 8

[Serge Gautherie (:sgautherie)]

This file was removed from 1.9(.0) trunk by
{{
1.80	bsmedberg%covad.net	2005-12-02 08:34	 	Bug 316416 - Convert nsIComponentLoader into nsIModuleLoader, xpcom bits r=darin xpconnect bits r=shaver; and bug 318625 - Make a version of nsTArray.AppendElement that doesn't copy-construct, r=darin
}}

R.Fixed.

1.8(.1) branch will stay as it is...