53936 - MOZ_DISABLE_JAR_PACKAGING should really disable JAR's

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Bernd]

If you look on
http://lxr.mozilla.org/seamonkey/source/config/rules.mak line 599 you will find
that even if you SET MOZ_DISABLE_JAR_PACKAGING=1 there is anyway a script for
jar-packaging involved (make-jars.pl). This script tries to feed a zip with a
command line longer than 255 chars .... See bug 53444 for the consequences.

Comment 1

[Bernd]

Finally I got my debug build running. I use it now. I did the following to get
it running.
1. I removed the SET MOZ_DISABLE_JAR_PACKAGING=1 from the autoexec.bat
2. I removed the -u argument for zip.exe in the make-jars.pl
3. I replaced my zip.exe, which was a 32bit DOS Version, with a Winxx-version.
The MS-DOS Version has 128 char limit for the arguments.

Probably the second step was not necessary.

Comment 2

[Daniel (Leaf) Nunes]

this looks like it might be quickly resolvable. Warren, why does make-jars.pl
even get called if we DISABLE jar packaging?

Comment 3

[Warren Harris]

At this point, make-jars.pl is a bit of a misnomer and probably should be 
copy-chrome-files-and-make-jars.pl -- it does both.

Bernd: Removing the -u option is not what we want here. You're going to spend a 
lot of time re-zipping things needlessly when rebuilding. Also cls put in some 
code over the weekend to limit the command line to 4k chars for posix. I'm sure 
this could be easily parameterizable for dos zip down to 128 chars (although 
it's going to be a little slower to run that way).

Comment 4

[cls]

Wrt original bug report, setting MOZ_DISABLE_JAR_PACKAGING actually does what it
says.  Make sure to remove dist before testing it.

Comment 5

[Doron Rosenberg (IBM)]

could someone verify this?