[HTML5] The translator isn't updating parser/html/javasrc/

RESOLVED FIXED

Status

()

P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: hsivonen, Assigned: mozilla+ben)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Looking at http://mxr.mozilla.org/mozilla-central/source/parser/html/javasrc/ , it turns out that the translator isn't storing a snapshot of the translated .java files in parser/html/javasrc/.

To make it easier for downstream packagers to use Gecko under the GPL, the translator should put a snapshot of the .java files in parser/html/javasrc/ and the makefile should allow using parser/html/javasrc/ as the translation source (in which case the translator shouldn't overwrite those files with the files themselves).
(Assignee)

Comment 1

9 years ago
Created attachment 433659 [details] [diff] [review]
Patch for htmlparser/translator-src/nu/validator/htmlparser/cpptranslate/Main.java

copyFile already contains a check to make sure the files don't overwrite themselves, so simply uncommenting the call should be sufficient
Attachment #433659 - Flags: review?(hsivonen)
(Assignee)

Comment 2

9 years ago
Created attachment 433660 [details] [diff] [review]
Add a translate_from_snapshot target to parser/html/java/Makefile.

Allows using the latest mozilla-central snapshot instead of the latest htmlparser revision.
Attachment #433660 - Flags: review?(hsivonen)
(Assignee)

Updated

9 years ago
Assignee: nobody → bnewman
(Reporter)

Updated

9 years ago
Attachment #433659 - Flags: review?(hsivonen) → review+
(Reporter)

Updated

9 years ago
Attachment #433660 - Flags: review?(hsivonen) → review+
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/projects/htmlparser/rev/fc1aa0e8ad45
http://hg.mozilla.org/mozilla-central/rev/1a9e1f278039
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.