539455 - [shared module] Request for location bar helper class (part of ToolbarAPI)

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Tracy Walker [:tracy]]

Listed below are items I think will be used most often

Elements within the awesomebar field itself:
- URL
- Favicon (can the actual favicon be determined?  not just that one is present)
- Star (empty and full(bookmarked))
- RSS feed icon (present or not)

Elements in autocomplete:
- Matched (sub)string in a list item  (matches for a single occurrence and for every occurrence) :
-- Title
-- URL
-- Favicon
-- Star
- list item count
-- # of visible items
-- Total # of items

others I haven't thought of?:
-
-

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets see which parts are possible. It's my next working item.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I will stick a location bar class into the new ToolbarAPI.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This patch implements two helper classes. One for the locationbar and the other for the auto-complete popup. Existing tests have been updated too.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1.1 [checked-in]

Now with the API added too.

Comment 5

[Aakash Desai [:aakashd]]

Comment on attachment 422216 [details] [diff] [review]
Patch v1.1 [checked-in]

passes on osx and winxp. No problems with syntax.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/95319da1cebb
http://hg.mozilla.org/qa/mozmill-tests/rev/e0a7a4018601

Go on Tracy!

Comment 7

[Tracy Walker [:tracy]]

A couple concerns:

1) Is assertTextUnderlined flexible enough to check title or URL individually?  It looks to me like a combined check for both. There will be cases when both will not necessarily match a given test string.  

2) for getElement, do the checks for the Star include whether it's empty (not bookmarked) or full (bookmarked)?  also, can this verify actual favicon.  Not just that one is present?

3) Is there some place that can do checks for actual favicon or star within popup list items. Again for the favicon, check match to expected site favicon,  not just that some favicon is present.

everything else looks good at first glance.  This will be very helpful.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #7)
> 1) Is assertTextUnderlined flexible enough to check title or URL individually? 
> It looks to me like a combined check for both. There will be cases when both
> will not necessarily match a given test string.  

What do you mean? URL and the title will always have the same characters underlined. There is really no difference.

> 2) for getElement, do the checks for the Star include whether it's empty (not
> bookmarked) or full (bookmarked)?  also, can this verify actual favicon.  Not
> just that one is present?

Retrieve the star via that function. If the page is bookmarked you can get from its property "bookmark". Same for the Favicon. Please check with DOMi to get all the available properties. 

> 3) Is there some place that can do checks for actual favicon or star within
> popup list items. Again for the favicon, check match to expected site favicon, 
> not just that some favicon is present.

Should all be properties of the result object.

Comment 9

[Tracy Walker [:tracy]]

(In reply to comment #8)
> (In reply to comment #7)
> > 1) Is assertTextUnderlined flexible enough to check title or URL individually? 
> > It looks to me like a combined check for both. There will be cases when both
> > will not necessarily match a given test string.  
> 
> What do you mean? URL and the title will always have the same characters
> underlined. There is really no difference.

No, our advanced match test case calls for checks of things like http:// and .org  Those usually won't be matched in the page title.  Conversely,  a string in the page title isn't necessarily going to be in the url. for example: "Mail" is in this page title but not in the url.  https://login.yahoo.com/config/login_verify2?&.src=ym

> Should all be properties of the result object.

Ok, I'll need some guidance on how to dig that stuff with these helpers.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Alright, I missed that. Let's reopen for an immediately follow-up fix. Will be ready today...

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Follow-up patch (underlined)

Separated the checks for underlined url and title. Now you can specify the type via a parameter.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Follow-up landes as:
http://hg.mozilla.org/qa/mozmill-tests/rev/0b744987e7e8
http://hg.mozilla.org/qa/mozmill-tests/rev/6be98c96fcd6

Other needs or changes we should discuss in the appropriate bugs.

Comment 13

[Tracy Walker [:tracy]]

Thanks Henrik.  These helpers will be, well, helpful. :-)  Expect questions and test cases from me to start trickling in next week.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Documentation has been created:
https://developer.mozilla.org/en/Mozmill_Tests/Shared_Modules/ToolbarAPI

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.