XPCShell dump warnings in our JS code

NEW
Unassigned

Status

Fennec Graveyard
General
--
trivial
8 years ago
8 years ago

People

(Reporter: vingtetun, Unassigned)

Tracking

Details

Attachments

(1 attachment)

Created attachment 421460 [details] [diff] [review]
Patch

Playing with openkomodo I've seen these warnings in the source code
Attachment #421460 - Flags: review?(mark.finkle)
Comment on attachment 421460 [details] [diff] [review]
Patch

>diff -r 736269688cd5 chrome/content/browser.js

> function importDialog(parent, src, arguments) {

>-  let parent = selectContainer.parentNode;
>+  parent = selectContainer.parentNode;

This means that the passed-in "parent" is ignored. I think it's only used internally, so perhaps we should just remove that argument? Or use a different name for this variable, if that's not feasible.
Comment on attachment 421460 [details] [diff] [review]
Patch

rebase and post a new patch
Attachment #421460 - Flags: review?(mark.finkle) → review-
You need to log in before you can comment on or make changes to this bug.