Closed
Bug 539461
Opened 15 years ago
Closed 6 years ago
XPCShell dump warnings in our JS code
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: vingtetun, Unassigned)
Details
Attachments
(1 file)
|
5.04 KB,
patch
|
mfinkle
:
review-
|
Details | Diff | Splinter Review |
Playing with openkomodo I've seen these warnings in the source code
Attachment #421460 -
Flags: review?(mark.finkle)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 421460 [details] [diff] [review]
Patch
>diff -r 736269688cd5 chrome/content/browser.js
> function importDialog(parent, src, arguments) {
>- let parent = selectContainer.parentNode;
>+ parent = selectContainer.parentNode;
This means that the passed-in "parent" is ignored. I think it's only used internally, so perhaps we should just remove that argument? Or use a different name for this variable, if that's not feasible.
|
||
Comment 2•15 years ago
|
||
Comment on attachment 421460 [details] [diff] [review]
Patch
rebase and post a new patch
Attachment #421460 -
Flags: review?(mark.finkle) → review-
|
||
Comment 3•6 years ago
|
||
Closing all opened bug in a graveyard component
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•