539481 - tile.cache.size default should be set every time Fennec loads

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

Right now, tile.cache.size is set to a positive value when a new profile is created.  Instead, every time we load Fennec if cache size is -1, we should use the device-specific default.  We should leave the preference at -1 in case we ever care to change the default.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Moves the tile cache "auto sizing" back to BrowserView. Leaves the N810 plugin disable code and "initNewProfile" alone.

Comment 2

[Benjamin Stover (:stechz)]

Comment on attachment 421674 [details] [diff] [review]
patch

>diff --git a/chrome/content/BrowserView.js b/chrome/content/BrowserView.js
>--- a/chrome/content/BrowserView.js
>+++ b/chrome/content/BrowserView.js
>@@ -243,17 +243,36 @@ BrowserView.prototype = {
> 
>     let cacheSize = kBrowserViewCacheSize;
>     try {
>       cacheSize = gPrefService.getIntPref("tile.cache.size");
>       // XXX cacheSize still can be -1 even though new profile sets it to a positive value
>       if (cacheSize == -1)
>         cacheSize = kBrowserViewCacheSize;
>     } catch(e) {}

Take this out so that cacheSize is still -1.  Otherwise the below code will do nothing.

r+ otherwise.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
<snip>
 
> Take this out so that cacheSize is still -1.  Otherwise the below code will do
> nothing.
> 
> r+ otherwise.

Nice catch. Serves me right for only looking at the single patch the made the initial change.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default with stechz'z change:
http://hg.mozilla.org/mobile-browser/rev/02dc280e8168