Always pause rendering during drag

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: stechz, Assigned: stechz)

Tracking

Trunk
x86
Mac OS X
Bug Flags:
in-litmus +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
When clicking in a scrollable div sometimes the page keeps rendering.
(Assignee)

Comment 1

8 years ago
Created attachment 421475 [details] [diff] [review]
patch
Attachment #421475 - Flags: review?(mark.finkle)
Comment on attachment 421475 [details] [diff] [review]
patch

> Browser.MainDragger.prototype = {
>   isDraggable: function isDraggable(target, scroller) { return true; },
> 
>   dragStart: function dragStart(clientX, clientY, target, scroller) {

>+    this.bv.pauseRendering();

Add a comment before this line saying that we want to make sure the rendering and crawling is paused before we hit any early returns.
Attachment #421475 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

8 years ago
Pushed http://hg.mozilla.org/mobile-browser/rev/ac15144f4aba
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Can you add a testcase to this bug, Ben? Either that or a website where you noticed this problem, it'd go a long way to helping QA as well as anyone else that reads this bug in the future.
(Assignee)

Comment 5

8 years ago
Go to youtube and try scrolling in the div pane.  Flash will keep rendering as you drag around.
Great, thanks for the testcase information. verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100114 Firefox/3.6pre Fennec/1.1a1pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Assignee: nobody → mozaakash
I'm reassigning this to myself for adding litmus testcases for this (aakashd discussed this on irc with blassey and ted on #mobile).
Assignee: mozaakash → martijn.martijn

Updated

8 years ago
Assignee: martijn.martijn → webapps
Flags: in-litmus? → in-litmus?(martijn.martijn)

Comment 8

7 years ago
https://litmus.mozilla.org/show_test.cgi?id=15187
Flags: in-litmus?(martijn.martijn) → in-litmus+
You need to log in before you can comment on or make changes to this bug.