539534 - Weave 1.0rc2 (and 1.0rc1) sync tabs with "Sync Tabs" option unchecked

Status: RESOLVED FIXED

Description

[Ben]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

I'm running Firefox 3.5.7 and Firefox 3.6rc1 on both Windows Vista and Windows 7. I've gone to the Weave Sync options, selected "Use my custom settings" and checked only "Sync Bookmarks" and "Sync Preferences". Even though "Sync Tabs" is unchecked my Firefox History -> Tabs From Other Computers still shows the tabs from my other computers and browsers.

Reproducible: Always

Steps to Reproduce:
1. Install Firefox 3.5.7 on computer 1 and computer 2
2. Install Mozilla Weave 1.0rc2 on computer 1 and computer 2
3. Set Mozilla Weave options on so "Firefox will: Use my custom settings" and check only "Sync Bookmarks" and "Sync Preferences"
4. Sync the browser session on computer 1
5. Sync the browser session on computer 2
6. Wait 30 seconds
7. On computer 2 go to History -> Tabs From Other Computers
8. If Tabs From Other Computers shows gray "No Tabs Available" repeat steps 6 and 7
Actual Results:  
The tabs from computer 1 were shown in the History -> Tabs From Other Computers of computer 2

Expected Results:  
There should be no "Tabs From Other Computers" shown

weave\logs\verbose-log.txt from computer 1

2010-01-13 15:17:27	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/meta/global
2010-01-13 15:17:27	Service.Main         DEBUG	Weave Version: 1.0rc2 Compatible: 1.0b3pre1 Remote: 1.0rc2
2010-01-13 15:17:27	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/info/collections
2010-01-13 15:17:27	Engine.Clients       INFO	0 outgoing items pre-reconciliation
2010-01-13 15:17:27	Store.Clients.Store  DEBUG	Updating client ComputerID1
2010-01-13 15:17:27	Collection           DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/clients?newer=1263416443.64&full=1&sort=index&limit=1500
2010-01-13 15:17:27	Engine.Clients       INFO	Records: 1 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:28	Engine.Clients       DEBUG	Total (ms): sync 289, processIncoming 283, uploadOutgoing 2, syncStartup 4, syncFinish 0, observe 0, reconcile 0
2010-01-13 15:17:28	Engine.Bookmarks     INFO	2 outgoing items pre-reconciliation
2010-01-13 15:17:28	Engine.Bookmarks     INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:28	Engine.Bookmarks     INFO	Uploading all of 2 records
2010-01-13 15:17:28	Collection           DEBUG	POST Length: 1003
2010-01-13 15:17:28	Collection           DEBUG	POST success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/bookmarks
2010-01-13 15:17:28	Engine.Bookmarks     DEBUG	Total (ms): sync 309, processIncoming 4, uploadOutgoing 294, syncStartup 4, syncFinish 4, createRecord 2
2010-01-13 15:17:28	Engine.Prefs         INFO	0 outgoing items pre-reconciliation
2010-01-13 15:17:28	Engine.Prefs         INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:28	Engine.Prefs         DEBUG	Total (ms): sync 5, processIncoming 2, uploadOutgoing 1, syncStartup 2, syncFinish 0
2010-01-13 15:17:28	Service.Main         INFO	Sync completed successfully

weave\logs\verbose-log.txt from computer 2

2010-01-13 15:17:11	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/meta/global
2010-01-13 15:17:11	Service.Main         DEBUG	Weave Version: 1.0rc2 Compatible: 1.0b3pre1 Remote: 1.0rc2
2010-01-13 15:17:11	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/info/collections
2010-01-13 15:17:11	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/crypto/clients
2010-01-13 15:17:11	Engine.Clients       DEBUG	First sync, uploading all items
2010-01-13 15:17:11	Engine.Clients       INFO	1 outgoing items pre-reconciliation
2010-01-13 15:17:11	Store.Clients.Store  DEBUG	Updating client ComputerID3
2010-01-13 15:17:11	Store.Clients.Store  DEBUG	Updating client ComputerID1
2010-01-13 15:17:11	Store.Clients.Store  DEBUG	Updating client ComputerID2
2010-01-13 15:17:11	Store.Clients.Store  DEBUG	Updating client ComputerID4
2010-01-13 15:17:11	Collection           DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/clients?full=1&sort=index&limit=1500
2010-01-13 15:17:11	Engine.Clients       INFO	Records: 4 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:11	Engine.Clients       INFO	Uploading all of 1 records
2010-01-13 15:17:11	Collection           DEBUG	POST Length: 139
2010-01-13 15:17:12	Collection           DEBUG	POST success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/clients
2010-01-13 15:17:12	Engine.Clients       DEBUG	Total (ms): sync 633, processIncoming 205, uploadOutgoing 195, syncStartup 233, syncFinish 0, observe 0, reconcile 0, createRecord 0
2010-01-13 15:17:12	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/crypto/bookmarks
2010-01-13 15:17:12	Engine.Bookmarks     INFO	0 outgoing items pre-reconciliation
2010-01-13 15:17:12	Engine.Bookmarks     INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:12	Engine.Bookmarks     DEBUG	Total (ms): sync 243, processIncoming 2, uploadOutgoing 2, syncStartup 214, syncFinish 4
2010-01-13 15:17:12	Net.Resource         DEBUG	GET success 200 https://sj-weave07.services.mozilla.com/1.0/MyWeaveUserName/storage/crypto/prefs
2010-01-13 15:17:12	Engine.Prefs         INFO	0 outgoing items pre-reconciliation
2010-01-13 15:17:12	Engine.Prefs         INFO	Records: 0 applied, 0 reconciled, 0 left to fetch
2010-01-13 15:17:12	Engine.Prefs         DEBUG	Total (ms): sync 313, processIncoming 2, uploadOutgoing 1, syncStartup 310, syncFinish 0
2010-01-13 15:17:12	Service.Main         INFO	Sync completed successfully

Thank you very much for a wonderful product.

Comment 1

[Ben]

Just to note that this is still an issue for me with Weave 1.0.

Comment 2

[Mike Connor [:mconnor]]

if you look in extensions.weave.engine.tabs, is that set to false?

Comment 3

[Ed Lee :Mardak (PTO Sep 15 - Oct 7)]

This might be the on-demand syncing when you access the remote tabs list. It might not be checking if the engine is enabled before TabEngine.sync(). Maybe that should be handled by each sync engine -- check if it's enabled before continuing. I guess this would also simplify the service.sync code to just always call sync without checking.

Comment 4

[Mike Connor [:mconnor]]

More stuff for bug 539056 and bug 517821 to resolve, in the short term.  In the longer term... we should revisit how we do that, as you noted.

Comment 5

[Ben]

I just checked extensions.weave.engine.tabs and it is user set to false.

Comment 6

[Mike Connor [:mconnor]]

The Firefox tabs UI is now inaccessible with Sync Tabs unchecked, so it's not possible to hit this except in a corner case (leaving the tab open and then disabling tab sync, then either forcing a refresh or having the tab restore through sessionstore).  Bug 556454 will make this last piece impossible, but I'm going to call this FIXED in the general case, and that bug is just belt-and-suspenders.