Closed Bug 539576 Opened 11 years ago Closed 11 years ago

SVGTransform matrix changes still not live in all circumstances

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached file patch (obsolete) —
setRotate, setSkewX, setSkewY create a new matrix so any references no longer update.

setting a value on the transform's matrix needs to turn the transform into a matrix transform.
Summary: SVGTransform still not live in all circumstances → SVGTransform matrix changes still not live in all circumstances
Assignee: nobody → longsonr
Attachment #421525 - Attachment is obsolete: true
Attachment #421596 - Flags: review?(jwatt)
Jonathan, can you take up with the SVG WG what the correct thing to do is if you set a skewX or skewY of 90 or some other value that would cause us to store infinities in a matrix?
BTW I think this can land without answering comment 3 really, providing it gets an r+ of course. After all we test for infinities throughout the code and this just adds some missing tests and returns the same code.
Comment on attachment 421596 [details] [diff] [review]
fix tests and prevent infinities

r=jwatt

I think I'd rather "eps" and "epsilon" were called "tolerance", and perhaps add a short comment stating what it's for/why it's necessary for the uninitiated. Up to you though.
Attachment #421596 - Flags: review?(jwatt) → review+
I also like the fact that the SVGMatrix object now doesn't change - it's more consistent with other parts of SVG (and more efficient in this case). :-)
I send a message to the SVG WG as requested in comment 3:

http://lists.w3.org/Archives/Public/www-svg/2010Jan/0085.html
(In reply to comment #5)
> I think I'd rather "eps" and "epsilon" were called "tolerance", and perhaps add
> a short comment stating what it's for/why it's necessary for the uninitiated.
> Up to you though.

Done.

pushed http://hg.mozilla.org/mozilla-central/rev/5f41d14731bc
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
reftest failures.
Status: RESOLVED → REOPENED
Flags: in-testsuite+
Resolution: FIXED → ---
pushed http://hg.mozilla.org/mozilla-central/rev/7808d51d7696
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.