539599 - Code Validation tool isn't producing the right results

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

The add-on in the URL should be showing multiple warnings, including several uses of 'eval'. The warning about the DLL is correct, so maybe it's just a partial failure somewhere.

This appears to be a regression from 5.5, because it was working fine just a couple of days ago.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: <3 regex

This was caused by r58196 and is a tough case.  Look aheads in regular expressions are not part of the match, they are just a condition.  So, this regex was searching for:  .*\.(anything but properties or dtd)$

But was matching:  .*\.$

Pretty confusing.  By sticking [A-Za-z] I'm matching any other alpha-extensions on a filename which solves the problem for me.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I hope this can be pushed *before* 5.6. The warnings being skipped by the tool are the most important to check for.

Comment 3

[Wil Clouser [:clouserw]]

Thanks RJ.  This is in r59958.  Jorge: can you verify on preview.amo?

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

It's not working for me here:
https://preview.addons.mozilla.org/en-US/developers/versions/validate/78574/run#test-results-64593
The overlay.js file has multiple instances of eval.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> It's not working for me here:
> https://preview.addons.mozilla.org/en-US/developers/versions/validate/78574/run#test-results-64593
> The overlay.js file has multiple instances of eval.

I had just checked it in.  preview takes a few minutes to update.  Have another look.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Oh, I'm too fast for you :P
Verified on the same link.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...