Closed Bug 539620 Opened 12 years ago Closed 12 years ago

Deprecate X-Content-Duration for Content-Duration

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

Someone from the W3C asked us to drop the X- prefix from the Content-Duration message header used to relay the duration of Ogg files for UI display when the server has this information. The X- carries no extra information, and 'Content-Duration' is itself already defined as a MIME header.

We're also in the process of registering Content-Duration as an official HTTP header, which is straightforward.

Reproducible: Always

Steps to Reproduce:
1. Return a video with Content-Duration http header
2.
3.
Actual Results:  
Firefox ignores the header, and performs byte range requests trying to determine the duration itself.

Expected Results:  
Firefox should parse the duration from the Content-Duration header as it currently does for X-Content-Duration.
Attached patch proposed patchSplinter Review
Proposed patch making the requested change.

The media element support is updated to accept Content-Duration.

Likewise, the tests are updated to send this header. A new test is added to verify support for the deprecated X-Content-Duration header.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → giles
Comment on attachment 421571 [details] [diff] [review]
proposed patch

Requesting review. Ideally this would go in as many branches as possible, but we can settle for 3.7.
Attachment #421571 - Flags: review?(chris.double)
Attachment #421571 - Flags: review?(chris.double) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/3cdf3bd2608c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.