539620 - Deprecate X-Content-Duration for Content-Duration

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

Someone from the W3C asked us to drop the X- prefix from the Content-Duration message header used to relay the duration of Ogg files for UI display when the server has this information. The X- carries no extra information, and 'Content-Duration' is itself already defined as a MIME header.

We're also in the process of registering Content-Duration as an official HTTP header, which is straightforward.

Reproducible: Always

Steps to Reproduce:
1. Return a video with Content-Duration http header
2.
3.
Actual Results:  
Firefox ignores the header, and performs byte range requests trying to determine the duration itself.

Expected Results:  
Firefox should parse the duration from the Content-Duration header as it currently does for X-Content-Duration.

Comment 1

[Ralph Giles (:rillian)]

Attachment: proposed patch

Proposed patch making the requested change.

The media element support is updated to accept Content-Duration.

Likewise, the tests are updated to send this header. A new test is added to verify support for the deprecated X-Content-Duration header.

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 421571 [details] [diff] [review]
proposed patch

Requesting review. Ideally this would go in as many branches as possible, but we can settle for 3.7.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3cdf3bd2608c