539645 - Print preview does not match what prints on animated images

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Drew Ruderman]

Attachment: Animated gif of a pilgrim with a turkey

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100113 Minefield/3.7a1pre (.NET CLR 3.5.30729)

This bug occurs in Trunk, not in 3.6 RC1.

Steps to Reproduce
1. Find an animated image (confirmed with GIF and PNG).
2. File | Print Preview when animated image is not displaying initial image.
3. Print.

The image shown in Print Preview in Step 2 and what is actually printed in Step 3 will be different (Step 3 seems to print a random part of the animation, so it will not always be reproducible).

Comment 1

[Drew Ruderman]

Attachment: Animated PNG of a supernova

Comment 2

[Drew Ruderman]

Between the below two builds, an error in which the animated image would become reanimated after printing (or going to the print screen and then canceling) in print preview mode seems to have been fixed.

It's difficult to tell because the image becomes reanimated, but I think that the current problem does not occur in the 12/12/09 build.

12/13/09: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091213 Minefield/3.7a1pre (.NET CLR 3.5.30729)
12/12/09: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Comment 3

[Drew Ruderman]

Disregard my last comment: it is the wrong build regression.

The bug seems to have been introduced in the 12/12/09 build below:

12/11/09: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091211 Minefield/3.7a1pre (.NET CLR 3.5.30729)

12/12/09: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre (.NET CLR 3.5.30729)

Revision ID: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9af2a428dcb1&tochange=d379a17cbf8f

I suspect that it was the following revision, as it is the only one that deals with printing:
180966423a3c	Olli Pettay — Bug 487667 - Clone documents for printing, r=roc+jst+joe+dbaron

Note: There is a bug in the earlier 12/11/09 build in which the animated image would become reanimated after printing or canceling a print job while in print preview mode.  I presume that the fix in the later 12/12/09 build introduced the current bug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We have had the same problem also before, just in a different situations.

This case, I assume, we clone the original document, not print preview.
Investigating.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Yeah, this was exactly what I expected.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 421916 [details] [diff] [review]
patch

Though, I think I'll fix this in a bit different way.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This is even a bit simpler.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 421919 [details] [diff] [review]
patch

Can we have a test for this?

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

I don't know any way to test this automatically.

Printing to a file and comparing it to something?

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

er yeah I guess we don't have any way to test actual printing :-(

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/196b9d7aef71