[HTML5][Patch] Serializer tests fail due to whitespace differences and doctype case differences

RESOLVED FIXED

Status

()

Core
HTML: Parser
P1
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
/tests/content/base/test/test_bug424359-1.html and
/tests/content/base/test/test_bug424359-2.html
fail due to differences in whitespace and the case of the string "html" in the doctype.
(Assignee)

Comment 1

8 years ago
Also content/base/test/test_bug498433.html
(Assignee)

Comment 2

8 years ago
Created attachment 422507 [details] [diff] [review]
Make serializer tests not depend on old vs. new parser differences

This patch does the following:
 * Removes whitespace before the first child of <head> to avoid hitting whitespace treatment differences between the old parser and the HTML5 parser.
 * Removes whitespace near the end of the document for the same reason.
 * Removes &lang; and &rang; testing, because those got reassigned. (I'll file a separate bug about dealing with the change in the serializer.)
 * Before comparing the actual and expected values, "<!DOCTYPE HTML" in actual is folded to "<!DOCTYPE html" to make the old parser pass.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #422507 - Flags: review?(laurent)
(Assignee)

Updated

8 years ago
Summary: [HTML5] Serializer tests fail due to whitespace differences and doctype case differences → [HTML5][Patch] Serializer tests fail due to whitespace differences and doctype case differences
(Assignee)

Comment 3

8 years ago
This patch assumes the patch for bug 520581 is applied first.
Depends on: 520581

Comment 4

8 years ago
Comment on attachment 422507 [details] [diff] [review]
Make serializer tests not depend on old vs. new parser differences

ok for me
Attachment #422507 - Flags: review?(laurent) → review+
(Assignee)

Comment 5

8 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/d8177ec0014c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.