539692 - Follow up to fix workaround for File/Edit/View menus having no names with some extension combinations

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

This is a follow-up to bug 398702. With some extension combinations, the File, Edit and View menus would have no names and some menu options not be present.

Attachment 420922 [details] [diff] provided a work around to Thunderbird, but it is suspected that there is a different issue. This bug will is intended to investigate the issue and replace the work around with a specific fix.

+++ This bug was initially created as a clone of Bug #398702 +++

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: Lightning 0.7rc1 + Buttons! 0.5.3.2 + Thunderbird 2.0.0.6

Running Thunderbird with Lightning and Buttons! extensions enabled.
The File, Edit and View menus in view message windows have no names.
The menus are still there but their names and some entries are blank.
The blank entries still work, if you know what they are.
Disabling either extension restores the menus.

Reproducible: Always

Steps to Reproduce:
1. Install lightning and Buttons! extensions
2. Double click an e-mail in the inbox to open a window
3. Look for the File, Edit and View menus
4. Click on one of the blank bits at the start of the menu bar
Actual Results:  
The first part of the menu bar is blank.  Small sections are highlighted when I mouse over and the menu appears when I click, but with the some entries blank.

Expected Results:  
File, Edit and View menus are visible

Blank menu items:
File
File->New
File->Close
Edit
Edit->Cut
Edit->Copy
Edit->Paste
View
View->Toolbars
View->Toolbars->Status bar
Tools->Options

Comment 1

[Jory A. Pratt [:anarchy]]

I am at a loss here, I retested everything a dozen times, and been unable to reproduce the bug when dom is enabled, everything works as expected. If someone has any advise please let me know and I will see what we can get to lead us in the right direction.

Comment 2

[Philip Chee]

The DOM Inspector itself overlays the mailWindowOverlay.xul so probably its overlay is "fixing" the problem or at least preventing it from manifesting.

Try this:
Edit the chrome.manifest of the DOM Inspector extension and comment out this line:

overlay chrome://messenger/content/mailWindowOverlay.xul chrome://inspector/content/tasksOverlay-tb.xul application={3550f703-e582-4d05-9a08-453d09bdfdc6}

Start Thunderbird with the commandline switch -inspector e.g.
thunderbird.exe -inspector

or perhaps:

thunderbird.exe -silent -inspector

You might want to install the inspector widget extension as well which gives you a convenient toolbarbutton to invoke the DOMi

Comment 3

[David :Bienvenu]

Doesn't sound like a blocker, since bug 398702 is fixed. If we get more information, feel free to renominate.

Comment 4

[Jory A. Pratt [:anarchy]]

Attachment: revert the bandaid patch

I have tested with as many extensions as I could possible test with, this is not needed any longer, I suggest we revert it.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Instead of just reverting this, I'd suggest to actually reproduce it before changing things. It was really hard to reproduce in the first place, so just reverting it might cause the same problems again for other users in the future.

Please try reproducing this with an older version of Thunderbird+Extension(s) back from the days where this showed up first. If you can reproduce with that combination and the same combination works now, then I'm happy.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 467600 [details] [diff] [review]
revert the bandaid patch

To reflect what Philipp said, I wouldn't accept this without a good explanation of either what's fixed it or what was wrong in the first place and why it is now fixed.

The only other way of "fixing" this that I can see at the moment would be to make utilityOverlay.xul redundant - this would probably mean working out what's necessary from utilityOverlay in each window and seeing if there's a better way (e.g. Firefox uses an include system for things like hiddenWindow).