Closed
Bug 539697
Opened 14 years ago
Closed 14 years ago
Return the correct failure code if we can't parse something in a script
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file, 1 obsolete file)
19.26 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
return the correct failure code if we can't parse something
Assignee | ||
Updated•14 years ago
|
OS: Windows Vista → All
Hardware: x86 → All
Assignee | ||
Updated•14 years ago
|
Attachment #421633 -
Attachment is patch: true
Attachment #421633 -
Flags: review?(jwatt)
Updated•14 years ago
|
Attachment #421633 -
Flags: review?(jwatt) → review+
Comment 1•14 years ago
|
||
For the record, the 2nd edition of SVG 1.1 made this change. See for example: http://dev.w3.org/SVG/profiles/1.1F2/publish/types.html#__svg__SVGLength__valueAsString
Assignee | ||
Comment 2•14 years ago
|
||
This patch is wrong then. *sigh*
Assignee | ||
Comment 3•14 years ago
|
||
Wrong units are NOT_SUPPORTED_ERR rather than a SYNTAX_ERR
Assignee: nobody → longsonr
Attachment #421633 -
Attachment is obsolete: true
Attachment #421646 -
Flags: review?(jwatt)
Assignee | ||
Updated•14 years ago
|
Summary: Return the correct failure code if we can't parse something → Return the correct failure code if we can't parse something in a script
Updated•14 years ago
|
Attachment #421646 -
Flags: review?(jwatt) → review+
Comment 4•14 years ago
|
||
Bugzilla won't give me a good interdiff, but your second patch is 19 KB vs the 36 KB of your first patch. I presume you purposely dropped some changes as well as changing some SYNTAX_ERR returns to NOT_SUPPORTED_ERR.
Assignee | ||
Comment 5•14 years ago
|
||
I purposely dropped some changes that were not necessary. I only want to change things that are called by script and not things that are called by the parser as they fall in the "If it ain't broke don't fix it category"
Comment 6•14 years ago
|
||
Makes sense. Just double checking you hadn't unintentionally lost some of your changes. :)
Comment 7•14 years ago
|
||
Getting some build errors on OSX: /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp: In member function ‘virtual nsresult DOMSVGAngle::NewValueSpecifiedUnits(PRUint16, float)’: /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:79: error: void value not ignored as it ought to be /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp: In member function ‘virtual nsresult DOMSVGAngle::ConvertToSpecifiedUnits(PRUint16)’: /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:83: error: void value not ignored as it ought to be /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp: At global scope: /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:247: error: prototype for ‘nsresult nsSVGAngle::ConvertToSpecifiedUnits(PRUint16, nsSVGElement*)’ does not match any in class ‘nsSVGAngle’ /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.h:90: error: candidate is: void nsSVGAngle::ConvertToSpecifiedUnits(PRUint16, nsSVGElement*) /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:247: error: ‘nsresult nsSVGAngle::ConvertToSpecifiedUnits(PRUint16, nsSVGElement*)’ cannot be overloaded /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.h:90: error: with ‘void nsSVGAngle::ConvertToSpecifiedUnits(PRUint16, nsSVGElement*)’ /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:261: error: prototype for ‘nsresult nsSVGAngle::NewValueSpecifiedUnits(PRUint16, float, nsSVGElement*)’ does not match any in class ‘nsSVGAngle’ /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.h:89: error: candidate is: void nsSVGAngle::NewValueSpecifiedUnits(PRUint16, float, nsSVGElement*) /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.cpp:261: error: ‘nsresult nsSVGAngle::NewValueSpecifiedUnits(PRUint16, float, nsSVGElement*)’ cannot be overloaded /Users/altape/moz/mozilla-central/content/svg/content/src/nsSVGAngle.h:89: error: with ‘void nsSVGAngle::NewValueSpecifiedUnits(PRUint16, float, nsSVGElement*)’ It looks like some of the header files weren't updated?
Comment 8•14 years ago
|
||
Looks like Thunderbird is on fire. http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1264017916.1264018131.4535.gz Firefox will probably follow soon. Backout?
Assignee | ||
Comment 9•14 years ago
|
||
Give me 2 minutes and I'll fix it.
Assignee | ||
Comment 10•14 years ago
|
||
Fix pushed with missing header files.
Assignee | ||
Comment 11•14 years ago
|
||
Fix seems to have worked
Assignee | ||
Comment 12•14 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/73ba1f723e0b and http://hg.mozilla.org/mozilla-central/rev/76a717c52203
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•